Window write support for SSD1673 #11351

vanwinkeljan · 2018-11-13T21:38:54Z

Added support for writing to a window instead of the complete display

codecov-io · 2018-11-13T22:20:00Z

Codecov Report

Merging #11351 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11351   +/-   ##
=======================================
  Coverage   48.17%   48.17%           
=======================================
  Files         281      281           
  Lines       43362    43362           
  Branches    10393    10393           
=======================================
  Hits        20889    20889           
  Misses      18318    18318           
  Partials     4155     4155

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ec7c73...bfb11c9. Read the comment docs.

vanwinkeljan · 2018-11-20T20:45:25Z

Addressed doc changes based on @dbkinder comments on PR #9149

dbkinder

+1 for doc changes

vanwinkeljan · 2018-11-21T10:49:37Z

@jfischer-phytec-iot any input?

drivers/display/ssd1673.c

pizi-nordic · 2018-11-21T15:25:36Z

include/display.h

@@ -48,6 +48,10 @@ enum display_screen_info {
 	 * Electrophoretic Display.
 	 */
 	SCREEN_INFO_EPD			= BIT(2),
+	/**
+	 * Screen has two alternating ram buffers


Could we do multiple writes to one buffer and then trigger update?

No currently there is no display_flush function available in the display API.

But SCREEN_INFO_DOUBLE_BUFFER is jut an indication to the higher layers, e.g. incase only a partial update of the display buffer is performed the same partial update needs to happen on the second buffer to keep the display content consistent.

jfischer-no

Please split 171c4f440d392618e905eec78d4762ae457476c5 in logical peaces and remove unnecessary code changes, keep the driver design and structure.

drivers/display/ssd1673.c

include/display.h

drivers/display/ssd1673.c

vanwinkeljan · 2018-11-30T22:13:43Z

@jfischer-phytec-iot Splitted commits as requested and provided replies where needed

nashif · 2018-12-04T21:09:32Z

@jfischer-phytec-iot feedback please

revisit

Moved the overlay configuration files to board directory. Signed-off-by: Jan Van Winkel <[email protected]>

Set width, height and pitch dimensions in character framebuffer before calling display write API. Signed-off-by: Jan Van Winkel <[email protected]>

Allow to set supported pixel format in ssd1306 & ssd1673 drivers Signed-off-by: Jan Van Winkel <[email protected]>

Added missing API function set_orientation to ssd1306 & ssd1673 drivers. Signed-off-by: Jan Van Winkel <[email protected]>

Return correct error codes in SSD1673 driver instead of -1 Signed-off-by: Jan Van Winkel <[email protected]>

Clear SSD1673 display during display driver initialization instead of triggering clear via setting contrast. Signed-off-by: Jan Van Winkel <[email protected]>

Added support to the SSD1673 dipslay for partially writing the display Signed-off-by: Jan Van Winkel <[email protected]>

Added missing README.rst for character frame buffer sample Signed-off-by: Jan Van Winkel <[email protected]>

vanwinkeljan · 2018-12-10T19:58:55Z

@jfischer-phytec-iot any further input?

vanwinkeljan requested a review from dbkinder as a code owner November 13, 2018 21:38

vanwinkeljan requested review from jfischer-no and pizi-nordic November 13, 2018 21:39

vanwinkeljan added the area: Display label Nov 13, 2018

This was referenced Nov 13, 2018

SDL based display emulation driver #9149

Merged

Added support for LittlevGL library #6826

Merged

vanwinkeljan mentioned this pull request Nov 20, 2018

[Coverity CID :189514]Possible Control flow issues in /drivers/display/ssd1673.c #11092

Closed

vanwinkeljan force-pushed the ssd1673_window branch from e6acc6c to 76061bc Compare November 20, 2018 20:40

dbkinder approved these changes Nov 20, 2018

View reviewed changes

pizi-nordic reviewed Nov 21, 2018

View reviewed changes

vanwinkeljan force-pushed the ssd1673_window branch from 76061bc to f8421d3 Compare November 22, 2018 21:30

nashif approved these changes Nov 23, 2018

View reviewed changes

vanwinkeljan force-pushed the ssd1673_window branch 2 times, most recently from 2dba962 to 5a7cd31 Compare November 27, 2018 17:09

carlescufi approved these changes Nov 27, 2018

View reviewed changes

jfischer-no previously requested changes Nov 30, 2018

View reviewed changes

vanwinkeljan force-pushed the ssd1673_window branch 2 times, most recently from ee00298 to 4a7db51 Compare November 30, 2018 22:07

vanwinkeljan force-pushed the ssd1673_window branch 2 times, most recently from 93af899 to 4326dbc Compare December 1, 2018 18:40

vanwinkeljan added 4 commits December 10, 2018 08:27

samples: cfb: Moved overlay config files to boards dir

6f8aa41

Moved the overlay configuration files to board directory. Signed-off-by: Jan Van Winkel <[email protected]>

cfb: Set dimensions in character framebuffer

f619dd8

Set width, height and pitch dimensions in character framebuffer before calling display write API. Signed-off-by: Jan Van Winkel <[email protected]>

drivers: Allow to set supported pix format in ssd drivers

163f6a1

Allow to set supported pixel format in ssd1306 & ssd1673 drivers Signed-off-by: Jan Van Winkel <[email protected]>

drivers: Added missing API functions in ssd drivers

d57811b

Added missing API function set_orientation to ssd1306 & ssd1673 drivers. Signed-off-by: Jan Van Winkel <[email protected]>

vanwinkeljan added 4 commits December 10, 2018 08:30

drivers: Return correct erorr codes in SSD1673 driver

85bc533

Return correct error codes in SSD1673 driver instead of -1 Signed-off-by: Jan Van Winkel <[email protected]>

drivers: Clear SSD1673 display during display init

fff1ddb

Clear SSD1673 display during display driver initialization instead of triggering clear via setting contrast. Signed-off-by: Jan Van Winkel <[email protected]>

drivers: display: Added windowing for SSD1673

5c73540

Added support to the SSD1673 dipslay for partially writing the display Signed-off-by: Jan Van Winkel <[email protected]>

samples: doc: Added README.rst for CFB sample

bfb11c9

Added missing README.rst for character frame buffer sample Signed-off-by: Jan Van Winkel <[email protected]>

vanwinkeljan force-pushed the ssd1673_window branch from 4326dbc to bfb11c9 Compare December 10, 2018 07:38

nashif merged commit 49466e0 into zephyrproject-rtos:master Dec 10, 2018

vanwinkeljan deleted the ssd1673_window branch December 10, 2018 22:41

vanwinkeljan mentioned this pull request Jan 31, 2019

display: ssd1673: replace k_busy_wait by k_sleep #12898

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Window write support for SSD1673 #11351

Window write support for SSD1673 #11351

vanwinkeljan commented Nov 13, 2018

codecov-io commented Nov 13, 2018 •

edited

Loading

vanwinkeljan commented Nov 20, 2018

dbkinder left a comment

vanwinkeljan commented Nov 21, 2018

pizi-nordic Nov 21, 2018

vanwinkeljan Nov 22, 2018

jfischer-no left a comment

vanwinkeljan commented Nov 30, 2018

nashif commented Dec 4, 2018

vanwinkeljan commented Dec 10, 2018

Window write support for SSD1673 #11351

Window write support for SSD1673 #11351

Conversation

vanwinkeljan commented Nov 13, 2018

codecov-io commented Nov 13, 2018 • edited Loading

Codecov Report

vanwinkeljan commented Nov 20, 2018

dbkinder left a comment

Choose a reason for hiding this comment

vanwinkeljan commented Nov 21, 2018

pizi-nordic Nov 21, 2018

Choose a reason for hiding this comment

vanwinkeljan Nov 22, 2018

Choose a reason for hiding this comment

jfischer-no left a comment

Choose a reason for hiding this comment

vanwinkeljan commented Nov 30, 2018

nashif commented Dec 4, 2018

vanwinkeljan commented Dec 10, 2018

codecov-io commented Nov 13, 2018 •

edited

Loading