Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup No SOURCES given to Zephyr library warnings #38403

Closed
tejlmand opened this issue Sep 9, 2021 · 5 comments · Fixed by #38471 or #38908
Closed

Cleanup No SOURCES given to Zephyr library warnings #38403

tejlmand opened this issue Sep 9, 2021 · 5 comments · Fixed by #38471 or #38908
Assignees
@tejlmand
Labels
bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Milestone
v2.7.0

Comments

@tejlmand
Copy link
Collaborator

tejlmand commented Sep 9, 2021

The #37512 cleanup PR created several new Zephyr libraries instead of adding sources to libzephyr.a.

Unfortunately, this also results in some libraries not having sources added to them in certain Kconfig combinations, resulting in the following warning being printed:

  No SOURCES given to Zephyr library: drivers__bluetooth

  Excluding target from build.

Expected behavior
No warning being printed

Impact
Annoyance, and bad user experience.
@tejlmand tejlmand added bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug labels Sep 9, 2021
@tejlmand tejlmand added this to the v2.7.0 milestone Sep 9, 2021
@tejlmand tejlmand self-assigned this Sep 9, 2021
@Thalley
Copy link
Collaborator

Thalley commented Sep 9, 2021

Related to #37770

@galak
Copy link
Collaborator

galak commented Sep 9, 2021

It seems like there are two possible approaches from a Kconfig point of view.

  1. introduce some form of <FOO>_HAS_DRIVER that gets selected by all the driver Kconfig symbols and is used to build the dir/lib. (See SERIAL_HAS_DRIVER for example)
  2. rework Kconfig's so things are menuconfig for each driver class, etc). Has ripple in how various boards/soc's have been selecting drivers

@tejlmand
Copy link
Collaborator Author

tejlmand commented Sep 10, 2021 •
edited
Loading 

1. introduce some form of `<FOO>_HAS_DRIVER` that gets selected by all the driver Kconfig symbols and is used to build the dir/lib.  (See `SERIAL_HAS_DRIVER` for example)

I have been considering such approach, but I feel it's like asking Kconfig to know about Zephyr CMake internals, as it starts to have symbols intended to help CMake.
Why should kconfig select a promptless symbol just to make things cleaner in CMake.

Of course, if such symbol is available for internal Kconfig purposes, like the SERIAL_HAS_DRIVER, then CMake can of course use such knowledge.

That being said, it could end-up being the cleanest solution short term.

  1. rework Kconfig's so things are menuconfig for each driver class, etc). Has ripple in how various boards/soc's have been selecting drivers

yes, this is a broader restructure, but could end-up with a more uniform way of selecting drivers in Kconfig in general.

@tejlmand
Copy link
Collaborator Author

  1. rework Kconfig's so things are menuconfig for each driver class, etc). Has ripple in how various boards/soc's have been selecting drivers

yes, this is a broader restructure, but could end-up with a more uniform way of selecting drivers in Kconfig in general.

Actually, majority of drivers are already using a menuconfig, only a fex exceptions like Bluetooth, interrupt, and Timer drivers.
image

So maybe we should use this opportunity to align those few to the rest.

@tejlmand tejlmand mentioned this issue Sep 10, 2021
Closed
tejlmand added a commit to tejlmand/zephyr that referenced this issue Sep 10, 2021
@tejlmand
drivers: create BT_DRIVERS Kconfig entry
457ad42 
Fixes: zephyrproject-rtos#38403

Changing Bluetooth drivers from being a menu into a menuconfig.
This aligns the Bluetooth driver configuration with other driver
configurations as well as provides a setting which identifies if
Bluetooth drivers has been enable.

This further helps to avoid empty Zephyr libraries for bluetooth
samples.

Signed-off-by: Torsten Rasmussen <[email protected]>
@tejlmand tejlmand mentioned this issue Sep 10, 2021
Merged
tejlmand added a commit to tejlmand/zephyr that referenced this issue Sep 14, 2021
@tejlmand
drivers: net: adding NET_DRIVERS menuconfig
138613f 
Fixes: zephyrproject-rtos#38403

Adding NET_DRIVERS menuconfig so that network drivers are grouped
together in its own menu entry under drivers, similar to most other
drivers.

This further has the advantages that `CONFIG_NET_DRIVERS` can be used
for testing to determine if network drivers has been selected.

This changed revealed a dependency flaw where both `select` (for SLIP)
and `depends` (for PPP) where in use in the dependency tree for
NET_SLIP_TAP. This dependency mess has been cleaned up, so that there
is a single direction dependency from NET_SLIP_TAP to SLIP and PPP.

Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand added a commit to tejlmand/zephyr that referenced this issue Sep 14, 2021
@tejlmand
drivers: ethernet: remove dedicated drivers__ethernet__native_posix lib
2935576 
Fixes: zephyrproject-rtos#38403

The two eth_native_posix.c and eth_native_posix_adapt.c are now added
to the common drivers__ethernet Zephyr library.

Instead of creating a dedicated library for just two files those files
are now added to the common ethernet library, see also zephyrproject-rtos#8826.
Instead, the dedicated compile definitions required for those files are
specified using COMPILE_DEFINITIONS on the source files.

This also avoids the following warning as the ethernet library is no
longer empty.

> No SOURCES given to Zephyr library: drivers__ethernet
>
> Excluding target from build.

Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand added a commit to tejlmand/zephyr that referenced this issue Sep 14, 2021
@tejlmand
drivers: pinmux: using zephyr_library_amend(pinmux) if pinmux exists
bf6ace5 
Fixes: zephyrproject-rtos#38403

A board might already have created a pinmux driver library.
If such library has already been created then amend to that library,
else the zephyr library is created in the drivers/pinmux CMakeLists.txt
file.

This ensures that pinmux source files from the board and drivers/pinmux
are placed in the same library.

Furthermore this avoids empty pinmux driver libraries and thus avoids
the following warning:
> No SOURCES given to Zephyr library: drivers__pinmux
>
> Excluding target from build.

Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand added a commit to tejlmand/zephyr that referenced this issue Sep 14, 2021
@tejlmand
drivers: gpio: remove unused GPIO selection
8160731 
Fixes: zephyrproject-rtos#38403

Removing unneeded `imply GPIO` and `CONFIG_GPIO=y` occurrences where no
files are added to the gpio zephyr library.

Selection of GPIO without selecting any drivers results in the warning:

> No SOURCES given to Zephyr library: drivers__gpio
>
> Excluding target from build.

Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand added a commit to tejlmand/zephyr that referenced this issue Sep 14, 2021
@tejlmand
drivers: net: adding NET_DRIVERS menuconfig
2dcfd42 
Fixes: zephyrproject-rtos#38403

Adding NET_DRIVERS menuconfig so that network drivers are grouped
together in its own menu entry under drivers, similar to most other
drivers.

This further has the advantages that `CONFIG_NET_DRIVERS` can be used
for testing to determine if network drivers has been selected.

This changed revealed a dependency flaw where both `select` (for SLIP)
and `depends` (for PPP) where in use in the dependency tree for
NET_SLIP_TAP. This dependency mess has been cleaned up, so that there
is a single direction dependency from NET_SLIP_TAP to SLIP and PPP.

Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand added a commit to tejlmand/zephyr that referenced this issue Sep 14, 2021
@tejlmand
drivers: ethernet: remove dedicated drivers__ethernet__native_posix lib
22f4e4d 
Fixes: zephyrproject-rtos#38403

The two eth_native_posix.c and eth_native_posix_adapt.c are now added
to the common drivers__ethernet Zephyr library.

Instead of creating a dedicated library for just two files those files
are now added to the common ethernet library, see also zephyrproject-rtos#8826.
Instead, the dedicated compile definitions required for those files are
specified using COMPILE_DEFINITIONS on the source files.

This also avoids the following warning as the ethernet library is no
longer empty.

> No SOURCES given to Zephyr library: drivers__ethernet
>
> Excluding target from build.

Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand added a commit to tejlmand/zephyr that referenced this issue Sep 14, 2021
@tejlmand
drivers: pinmux: using zephyr_library_amend(pinmux) if pinmux exists
8e123a2 
Fixes: zephyrproject-rtos#38403

A board might already have created a pinmux driver library.
If such library has already been created then amend to that library,
else the zephyr library is created in the drivers/pinmux CMakeLists.txt
file.

This ensures that pinmux source files from the board and drivers/pinmux
are placed in the same library.

Furthermore this avoids empty pinmux driver libraries and thus avoids
the following warning:
> No SOURCES given to Zephyr library: drivers__pinmux
>
> Excluding target from build.

Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand added a commit to tejlmand/zephyr that referenced this issue Sep 14, 2021
@tejlmand
drivers: gpio: remove unused GPIO selection
0817807 
Fixes: zephyrproject-rtos#38403

Removing unneeded `imply GPIO` and `CONFIG_GPIO=y` occurrences where no
files are added to the gpio zephyr library.

Also removed `CONFIG_GPIO=y` occurences where this is handled by
defconfigs for the soc or board.

Selection of GPIO without selecting any drivers results in the warning:

> No SOURCES given to Zephyr library: drivers__gpio
>
> Excluding target from build.

Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand added a commit to tejlmand/zephyr that referenced this issue Sep 16, 2021
@tejlmand
drivers: create BT_DRIVERS Kconfig entry
b3d8063 
Fixes: zephyrproject-rtos#38403

Changing Bluetooth drivers from being a menu into a menuconfig.
This aligns the Bluetooth driver configuration with other driver
configurations as well as provides a setting which identifies if
Bluetooth drivers has been enable.

This further helps to avoid empty Zephyr libraries for bluetooth
samples.

Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand added a commit to tejlmand/zephyr that referenced this issue Sep 16, 2021
@tejlmand
drivers: net: adding NET_DRIVERS menuconfig
76df635 
Fixes: zephyrproject-rtos#38403

Adding NET_DRIVERS menuconfig so that network drivers are grouped
together in its own menu entry under drivers, similar to most other
drivers.

This further has the advantages that `CONFIG_NET_DRIVERS` can be used
for testing to determine if network drivers has been selected.

This changed revealed a dependency flaw where both `select` (for SLIP)
and `depends` (for PPP) where in use in the dependency tree for
NET_SLIP_TAP. This dependency mess has been cleaned up, so that there
is a single direction dependency from NET_SLIP_TAP to SLIP and PPP.

Signed-off-by: Torsten Rasmussen <[email protected]>
@tejlmand tejlmand mentioned this issue Sep 28, 2021
Closed
carlescufi pushed a commit that referenced this issue Sep 28, 2021
@tejlmand @carlescufi
drivers: create BT_DRIVERS Kconfig entry
6ebe0b8 
Fixes: #38403

Changing Bluetooth drivers from being a menu into a menuconfig.
This aligns the Bluetooth driver configuration with other driver
configurations as well as provides a setting which identifies if
Bluetooth drivers has been enable.

This further helps to avoid empty Zephyr libraries for bluetooth
samples.

Signed-off-by: Torsten Rasmussen <[email protected]>
carlescufi pushed a commit that referenced this issue Sep 28, 2021
@tejlmand @carlescufi
drivers: net: adding NET_DRIVERS menuconfig
8e64038 
Fixes: #38403

Adding NET_DRIVERS menuconfig so that network drivers are grouped
together in its own menu entry under drivers, similar to most other
drivers.

This further has the advantages that `CONFIG_NET_DRIVERS` can be used
for testing to determine if network drivers has been selected.

This changed revealed a dependency loop where both `select` (for SLIP)
and `depends` (for PPP) which both depends on NET_DRIVERS` where in use
in the dependency tree for Qemu networking, especially NET_SLIP_TAP.

This is handled by defaulting `NET_DRIVERS` to `y` when building for a
Qemu target.
`SLIP` had a dependency to `!QEMU_TARGET || NET_QEMU_SLIP`. This is
changed so that SLIP prompt depends on `!QEMU_TARGET` which provides
full user control in hardware but makes the symbol promptless on Qemu
targets.

Signed-off-by: Torsten Rasmussen <[email protected]>
carlescufi pushed a commit that referenced this issue Sep 28, 2021
@tejlmand @carlescufi
drivers: ethernet: remove dedicated drivers__ethernet__native_posix lib
e8eb8a8 
Fixes: #38403

The two eth_native_posix.c and eth_native_posix_adapt.c are now added
to the common drivers__ethernet Zephyr library.

Instead of creating a dedicated library for just two files those files
are now added to the common ethernet library, see also #8826.
Instead, the dedicated compile definitions required for those files are
specified using COMPILE_DEFINITIONS on the source files.

This also avoids the following warning as the ethernet library is no
longer empty.

> No SOURCES given to Zephyr library: drivers__ethernet
>
> Excluding target from build.

Signed-off-by: Torsten Rasmussen <[email protected]>
carlescufi pushed a commit that referenced this issue Sep 28, 2021
@tejlmand @carlescufi
drivers: gpio: remove unused GPIO selection
d800b4a 
Fixes: #38403

Removing unneeded `imply GPIO` and `CONFIG_GPIO=y` occurrences where no
files are added to the gpio zephyr library.

Also removed `CONFIG_GPIO=y` occurences where this is handled by
defconfigs for the soc or board.

Selection of GPIO without selecting any drivers results in the warning:

> No SOURCES given to Zephyr library: drivers__gpio
>
> Excluding target from build.

Signed-off-by: Torsten Rasmussen <[email protected]>
carlescufi pushed a commit that referenced this issue Sep 28, 2021
@tejlmand @carlescufi
drivers: console: remove unused CONSOLE selection
72a8520 
Fixes: #38403

Removing unneeded `CONFIG_CONSOLES=y` occurrences where no console
driver is selected.

Such selection results in an empty drivers__console zephyr library,
which again results in the following warning message.

> No SOURCES given to Zephyr library: drivers__console
>
> Excluding target from build.

Signed-off-by: Torsten Rasmussen <[email protected]>
zephyrbot pushed a commit that referenced this issue Sep 28, 2021
@tejlmand @github-actions
drivers: create BT_DRIVERS Kconfig entry
cd71145 
Fixes: #38403

Changing Bluetooth drivers from being a menu into a menuconfig.
This aligns the Bluetooth driver configuration with other driver
configurations as well as provides a setting which identifies if
Bluetooth drivers has been enable.

This further helps to avoid empty Zephyr libraries for bluetooth
samples.

Signed-off-by: Torsten Rasmussen <[email protected]>
zephyrbot pushed a commit that referenced this issue Sep 28, 2021
@tejlmand @github-actions
drivers: net: adding NET_DRIVERS menuconfig
85d18d4 
Fixes: #38403

Adding NET_DRIVERS menuconfig so that network drivers are grouped
together in its own menu entry under drivers, similar to most other
drivers.

This further has the advantages that `CONFIG_NET_DRIVERS` can be used
for testing to determine if network drivers has been selected.

This changed revealed a dependency loop where both `select` (for SLIP)
and `depends` (for PPP) which both depends on NET_DRIVERS` where in use
in the dependency tree for Qemu networking, especially NET_SLIP_TAP.

This is handled by defaulting `NET_DRIVERS` to `y` when building for a
Qemu target.
`SLIP` had a dependency to `!QEMU_TARGET || NET_QEMU_SLIP`. This is
changed so that SLIP prompt depends on `!QEMU_TARGET` which provides
full user control in hardware but makes the symbol promptless on Qemu
targets.

Signed-off-by: Torsten Rasmussen <[email protected]>
zephyrbot pushed a commit that referenced this issue Sep 28, 2021
@tejlmand @github-actions
drivers: ethernet: remove dedicated drivers__ethernet__native_posix lib
d511f23 
Fixes: #38403

The two eth_native_posix.c and eth_native_posix_adapt.c are now added
to the common drivers__ethernet Zephyr library.

Instead of creating a dedicated library for just two files those files
are now added to the common ethernet library, see also #8826.
Instead, the dedicated compile definitions required for those files are
specified using COMPILE_DEFINITIONS on the source files.

This also avoids the following warning as the ethernet library is no
longer empty.

> No SOURCES given to Zephyr library: drivers__ethernet
>
> Excluding target from build.

Signed-off-by: Torsten Rasmussen <[email protected]>
zephyrbot pushed a commit that referenced this issue Sep 28, 2021
@tejlmand @github-actions
drivers: gpio: remove unused GPIO selection
40e641d 
Fixes: #38403

Removing unneeded `imply GPIO` and `CONFIG_GPIO=y` occurrences where no
files are added to the gpio zephyr library.

Also removed `CONFIG_GPIO=y` occurences where this is handled by
defconfigs for the soc or board.

Selection of GPIO without selecting any drivers results in the warning:

> No SOURCES given to Zephyr library: drivers__gpio
>
> Excluding target from build.

Signed-off-by: Torsten Rasmussen <[email protected]>
zephyrbot pushed a commit that referenced this issue Sep 28, 2021
@tejlmand @github-actions
drivers: console: remove unused CONSOLE selection
d12331e 
Fixes: #38403

Removing unneeded `CONFIG_CONSOLES=y` occurrences where no console
driver is selected.

Such selection results in an empty drivers__console zephyr library,
which again results in the following warning message.

> No SOURCES given to Zephyr library: drivers__console
>
> Excluding target from build.

Signed-off-by: Torsten Rasmussen <[email protected]>
@tejlmand
Copy link
Collaborator Author

still a pending PR to be fully fixed: #38908

@tejlmand tejlmand reopened this Sep 28, 2021
carlescufi pushed a commit that referenced this issue Sep 28, 2021
@tejlmand @carlescufi
Revert "drivers: pinmux: build as static library"
34e346d 
This reverts commit 4330929.

Fixes: #38403

The referred commit introduced `zephyr_library()` for pinmux drivers but
also resulting in #38403 because several boards has `CONFIG_PINMUX=y`
without selecting any pinmux drivers from `drivers/pinmux` thus
generating the following warning:
> No SOURCES given to Zephyr library: drivers__pinmux
>
> Excluding target from build.

This commit reverts the changes so that this warning disappears.
This results in pinmux drivers from `drivers/pinmux` to be located in
libzephyr.a which is messy, but has been so for a long time, even before
Zephyr 1.14 LTS.

The future pinctrl API will be designed in such a way that this problem
will not occur. Thus the old behavior is acceptable until the transition
to pinctrl API has completed.

Signed-off-by: Torsten Rasmussen <[email protected]>
zephyrbot pushed a commit that referenced this issue Sep 28, 2021
@tejlmand @github-actions
Revert "drivers: pinmux: build as static library"
c43e05a 
This reverts commit 4330929.

Fixes: #38403

The referred commit introduced `zephyr_library()` for pinmux drivers but
also resulting in #38403 because several boards has `CONFIG_PINMUX=y`
without selecting any pinmux drivers from `drivers/pinmux` thus
generating the following warning:
> No SOURCES given to Zephyr library: drivers__pinmux
>
> Excluding target from build.

This commit reverts the changes so that this warning disappears.
This results in pinmux drivers from `drivers/pinmux` to be located in
libzephyr.a which is messy, but has been so for a long time, even before
Zephyr 1.14 LTS.

The future pinctrl API will be designed in such a way that this problem
will not occur. Thus the old behavior is acceptable until the transition
to pinctrl API has completed.

Signed-off-by: Torsten Rasmussen <[email protected]>
cfriedt pushed a commit that referenced this issue Oct 2, 2021
@tejlmand @cfriedt
drivers: create BT_DRIVERS Kconfig entry
30eadf7 
Fixes: #38403

Changing Bluetooth drivers from being a menu into a menuconfig.
This aligns the Bluetooth driver configuration with other driver
configurations as well as provides a setting which identifies if
Bluetooth drivers has been enable.

This further helps to avoid empty Zephyr libraries for bluetooth
samples.

Signed-off-by: Torsten Rasmussen <[email protected]>
cfriedt pushed a commit that referenced this issue Oct 2, 2021
@tejlmand @cfriedt
drivers: net: adding NET_DRIVERS menuconfig
c3fac65 
Fixes: #38403

Adding NET_DRIVERS menuconfig so that network drivers are grouped
together in its own menu entry under drivers, similar to most other
drivers.

This further has the advantages that `CONFIG_NET_DRIVERS` can be used
for testing to determine if network drivers has been selected.

This changed revealed a dependency loop where both `select` (for SLIP)
and `depends` (for PPP) which both depends on NET_DRIVERS` where in use
in the dependency tree for Qemu networking, especially NET_SLIP_TAP.

This is handled by defaulting `NET_DRIVERS` to `y` when building for a
Qemu target.
`SLIP` had a dependency to `!QEMU_TARGET || NET_QEMU_SLIP`. This is
changed so that SLIP prompt depends on `!QEMU_TARGET` which provides
full user control in hardware but makes the symbol promptless on Qemu
targets.

Signed-off-by: Torsten Rasmussen <[email protected]>
cfriedt pushed a commit that referenced this issue Oct 2, 2021
@tejlmand @cfriedt
drivers: ethernet: remove dedicated drivers__ethernet__native_posix lib
f7d0ae5 
Fixes: #38403

The two eth_native_posix.c and eth_native_posix_adapt.c are now added
to the common drivers__ethernet Zephyr library.

Instead of creating a dedicated library for just two files those files
are now added to the common ethernet library, see also #8826.
Instead, the dedicated compile definitions required for those files are
specified using COMPILE_DEFINITIONS on the source files.

This also avoids the following warning as the ethernet library is no
longer empty.

> No SOURCES given to Zephyr library: drivers__ethernet
>
> Excluding target from build.

Signed-off-by: Torsten Rasmussen <[email protected]>
cfriedt pushed a commit that referenced this issue Oct 2, 2021
@tejlmand @cfriedt
drivers: gpio: remove unused GPIO selection
0ad4b44 
Fixes: #38403

Removing unneeded `imply GPIO` and `CONFIG_GPIO=y` occurrences where no
files are added to the gpio zephyr library.

Also removed `CONFIG_GPIO=y` occurences where this is handled by
defconfigs for the soc or board.

Selection of GPIO without selecting any drivers results in the warning:

> No SOURCES given to Zephyr library: drivers__gpio
>
> Excluding target from build.

Signed-off-by: Torsten Rasmussen <[email protected]>
cfriedt pushed a commit that referenced this issue Oct 2, 2021
@tejlmand @cfriedt
drivers: console: remove unused CONSOLE selection
cf112e2 
Fixes: #38403

Removing unneeded `CONFIG_CONSOLES=y` occurrences where no console
driver is selected.

Such selection results in an empty drivers__console zephyr library,
which again results in the following warning message.

> No SOURCES given to Zephyr library: drivers__console
>
> Excluding target from build.

Signed-off-by: Torsten Rasmussen <[email protected]>
cfriedt pushed a commit that referenced this issue Oct 2, 2021
@tejlmand @cfriedt
Revert "drivers: pinmux: build as static library"
eb85f9a 
This reverts commit 4330929.

Fixes: #38403

The referred commit introduced `zephyr_library()` for pinmux drivers but
also resulting in #38403 because several boards has `CONFIG_PINMUX=y`
without selecting any pinmux drivers from `drivers/pinmux` thus
generating the following warning:
> No SOURCES given to Zephyr library: drivers__pinmux
>
> Excluding target from build.

This commit reverts the changes so that this warning disappears.
This results in pinmux drivers from `drivers/pinmux` to be located in
libzephyr.a which is messy, but has been so for a long time, even before
Zephyr 1.14 LTS.

The future pinctrl API will be designed in such a way that this problem
will not occur. Thus the old behavior is acceptable until the transition
to pinctrl API has completed.

Signed-off-by: Torsten Rasmussen <[email protected]>
Rushybrook pushed a commit to Rushybrook/zephyr that referenced this issue Oct 21, 2021
@tejlmand @Rushybrook
drivers: create BT_DRIVERS Kconfig entry
c4a6e6d 
Fixes: zephyrproject-rtos#38403

Changing Bluetooth drivers from being a menu into a menuconfig.
This aligns the Bluetooth driver configuration with other driver
configurations as well as provides a setting which identifies if
Bluetooth drivers has been enable.

This further helps to avoid empty Zephyr libraries for bluetooth
samples.

Signed-off-by: Torsten Rasmussen <[email protected]>
Rushybrook pushed a commit to Rushybrook/zephyr that referenced this issue Oct 21, 2021
@tejlmand @Rushybrook
drivers: net: adding NET_DRIVERS menuconfig
bf870e5 
Fixes: zephyrproject-rtos#38403

Adding NET_DRIVERS menuconfig so that network drivers are grouped
together in its own menu entry under drivers, similar to most other
drivers.

This further has the advantages that `CONFIG_NET_DRIVERS` can be used
for testing to determine if network drivers has been selected.

This changed revealed a dependency loop where both `select` (for SLIP)
and `depends` (for PPP) which both depends on NET_DRIVERS` where in use
in the dependency tree for Qemu networking, especially NET_SLIP_TAP.

This is handled by defaulting `NET_DRIVERS` to `y` when building for a
Qemu target.
`SLIP` had a dependency to `!QEMU_TARGET || NET_QEMU_SLIP`. This is
changed so that SLIP prompt depends on `!QEMU_TARGET` which provides
full user control in hardware but makes the symbol promptless on Qemu
targets.

Signed-off-by: Torsten Rasmussen <[email protected]>
Rushybrook pushed a commit to Rushybrook/zephyr that referenced this issue Oct 21, 2021
@tejlmand @Rushybrook
drivers: ethernet: remove dedicated drivers__ethernet__native_posix lib
8fee787 
Fixes: zephyrproject-rtos#38403

The two eth_native_posix.c and eth_native_posix_adapt.c are now added
to the common drivers__ethernet Zephyr library.

Instead of creating a dedicated library for just two files those files
are now added to the common ethernet library, see also zephyrproject-rtos#8826.
Instead, the dedicated compile definitions required for those files are
specified using COMPILE_DEFINITIONS on the source files.

This also avoids the following warning as the ethernet library is no
longer empty.

> No SOURCES given to Zephyr library: drivers__ethernet
>
> Excluding target from build.

Signed-off-by: Torsten Rasmussen <[email protected]>
Rushybrook pushed a commit to Rushybrook/zephyr that referenced this issue Oct 21, 2021
@tejlmand @Rushybrook
drivers: gpio: remove unused GPIO selection
9a41110 
Fixes: zephyrproject-rtos#38403

Removing unneeded `imply GPIO` and `CONFIG_GPIO=y` occurrences where no
files are added to the gpio zephyr library.

Also removed `CONFIG_GPIO=y` occurences where this is handled by
defconfigs for the soc or board.

Selection of GPIO without selecting any drivers results in the warning:

> No SOURCES given to Zephyr library: drivers__gpio
>
> Excluding target from build.

Signed-off-by: Torsten Rasmussen <[email protected]>
Rushybrook pushed a commit to Rushybrook/zephyr that referenced this issue Oct 21, 2021
@tejlmand @Rushybrook
drivers: console: remove unused CONSOLE selection
3971a6c 
Fixes: zephyrproject-rtos#38403

Removing unneeded `CONFIG_CONSOLES=y` occurrences where no console
driver is selected.

Such selection results in an empty drivers__console zephyr library,
which again results in the following warning message.

> No SOURCES given to Zephyr library: drivers__console
>
> Excluding target from build.

Signed-off-by: Torsten Rasmussen <[email protected]>
Rushybrook pushed a commit to Rushybrook/zephyr that referenced this issue Oct 21, 2021
@tejlmand @Rushybrook
Revert "drivers: pinmux: build as static library"
c667129 
This reverts commit 4330929.

Fixes: zephyrproject-rtos#38403

The referred commit introduced `zephyr_library()` for pinmux drivers but
also resulting in zephyrproject-rtos#38403 because several boards has `CONFIG_PINMUX=y`
without selecting any pinmux drivers from `drivers/pinmux` thus
generating the following warning:
> No SOURCES given to Zephyr library: drivers__pinmux
>
> Excluding target from build.

This commit reverts the changes so that this warning disappears.
This results in pinmux drivers from `drivers/pinmux` to be located in
libzephyr.a which is messy, but has been so for a long time, even before
Zephyr 1.14 LTS.

The future pinctrl API will be designed in such a way that this problem
will not occur. Thus the old behavior is acceptable until the transition
to pinctrl API has completed.

Signed-off-by: Torsten Rasmussen <[email protected]>
@tejlmand tejlmand mentioned this issue Nov 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tejlmand tejlmand

Labels
bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Milestone
v2.7.0
3 participants
@Thalley @tejlmand @galak