net: tcp: Do not mark TCP segment not sent in net_if

If the TCP segment is not sent properly by L2, then do not mark it "not sent" in net_if.c:net_if_tx(). That "not sent" marking confused TCP ref counting in tcp.c:tcp_retry_expired() and caused the packet to be freed too early which then caused free net_buf access issue during packet resend. This free memory access was seen with zperf sample application. From TCP point of view, the packet can be considered sent when it is given to L2. The TCP timer will resend the packet if needed. Fixes #15050 Signed-off-by: Jukka Rissanen <[email protected]>
zephyrproject-rtos · Apr 1, 2019 · 1eead93 · 1eead93
1 parent 30d3193
commit 1eead93
Showing 1 changed file with 0 additions and 5 deletions.
diff --git a/subsys/net/ip/net_if.c b/subsys/net/ip/net_if.c
@@ -165,11 +165,6 @@ static bool net_if_tx(struct net_if *iface, struct net_pkt *pkt)
 	}
 
 	if (status < 0) {
-		if (IS_ENABLED(CONFIG_NET_TCP)
-		    && net_pkt_family(pkt) != AF_UNSPEC) {
-			net_pkt_set_sent(pkt, false);
-		}
-
 		net_pkt_unref(pkt);
 	} else {
 		net_stats_update_bytes_sent(iface, status);