zephyrCommon: Implement analogRead()/analogReference() #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DhruvaG2000
reviewed
Sep 25, 2022
DhruvaG2000
requested changes
Sep 25, 2022
| @@ -0,0 +1,4 @@ | |||
| CONFIG_GPIO=y | |||
| CONFIG_ADC=y | |||
There was a problem hiding this comment.
I think all this can be shifted into the project's global KConfig
DhruvaG2000
requested changes
Sep 25, 2022
samples/analog_input/README.rst
Outdated
| :goals: build flash | ||
| :compact: | ||
|
|
||
| Change ``arduino_nano_33_ble`` appropriately for other supported boards. |
There was a problem hiding this comment.
This README needs updating.
There was a problem hiding this comment.
I forgot it.😱
Update README did.
The 'io-channels' node under the 'zephyr,user' defines available ADC channels. The 'io-channel-pins' defines the mapping of ADC channels to pin numbers. API looks up the 'io-channel-pins' when querying the ADC channel by digital pin number. So it should be in the same order as 'io-channels' node. For original Arduino API compatibility, adc resolution should configure as 10-bit. ADC that is on MCU supported by Zephyr exists only 16-bit resolution currently. So it supports resolutions up to 16-bit. Signed-off-by: TOKITA Hiroshi <[email protected]>
Add a sample to demonstrate how to use analogRead API Signed-off-by: TOKITA Hiroshi <[email protected]>
|
@DhruvaG2000 |
|
Code looks good, but let me test this patch on real hardware before approving and merging. |
Okay, No need to hurry |
DhruvaG2000
approved these changes
Oct 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'io-channels' node under the 'zephyr,user' defines
available ADC channels.
The 'io-channel-pins' defines the mapping of ADC channels
to pin numbers. API looks up the 'io-channel-pins' when
querying the ADC channel by digital pin number.
So it should be in the same order as 'io-channels' node.
For original Arduino API compatibility, ADC resolution
should configure as 10-bit.
ADC that is on MCU supported by Zephyr exists
only 16-bit resolution currently.
So it supports resolutions up to 16-bit.
Signed-off-by: TOKITA Hiroshi [email protected]