Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile.ci: v0.26.0: PyYAML from renode python requirements conflicts with zephyr's one #145

Closed
avolkov-1221 opened this issue Mar 23, 2023 · 3 comments · Fixed by #147
Closed

Dockerfile.ci: v0.26.0: PyYAML from renode python requirements conflicts with zephyr's one #145

avolkov-1221 opened this issue Mar 23, 2023 · 3 comments · Fixed by #147
Assignees
@stephanosio

Comments

@avolkov-1221
Copy link

Hello,

Renode requires hardcoded PyYAML == 6.0 while awscli and friends want PyYAML >= 5.4 and < 6.0, so an older PyYAML is suddenly installed, with probably unpredictable results in all Renode dependent tests.

AFAIS scripts/requirements-*.txt should be updated to use newer packages and hopefully avoid above problem.
@knthm
Copy link
Contributor

knthm commented Mar 24, 2023 •
edited
Loading

Unfortunately awscli is the problem here. I wanted to bump the Zephyr's pyOCD version, but also ran into the conflict of awscli not liking PyYAML>5.4.

See aws/aws-cli#5943.

We'll be stuck with this until aws/aws-cli#6648 gets merged (open for over a year), or we replace awscli with awscliv2.

EDIT: it seems we've already ditched awscli in 1a45b6e but then reverted that in 5419d69.

@stephanosio I think we should still remove awscli, do you know if awscliv2 could replace it in CI workflows that require it?

@stephanosio
Copy link
Member

@stephanosio I think we should still remove awscli, do you know if awscliv2 could replace it in CI workflows that require it?

As far as I can see, we are not using the awscli package directly anywhere in our CI. I will send a patch to remove it (or migrate to awscliv2).

@stephanosio stephanosio self-assigned this Apr 12, 2023
stephanosio added a commit to stephanosio/zephyr-docker-image that referenced this issue Apr 12, 2023
@stephanosio
Dockerfile: Remove awscli Python package
bcb2886 
This commit removes the `awscli` Python package from the base CI image
because it is not currently not used by any Zephyr CI workflows and has
`PyYAML` dependency conflict with the Renode (see the GH issue zephyrproject-rtos#145).

If the AWS command line tool is necessary in the future, look into
either migrating to the `awscliv2` or installing the `awscli` package
in a virtual environment.

Signed-off-by: Stephanos Ioannidis <[email protected]>
@stephanosio stephanosio mentioned this issue Apr 12, 2023
Merged
@stephanosio
Copy link
Member

awscli will be removed in #147

stephanosio added a commit that referenced this issue Apr 12, 2023
@stephanosio
Dockerfile: Remove awscli Python package
aa1b43c 
This commit removes the `awscli` Python package from the base CI image
because it is not currently not used by any Zephyr CI workflows and has
`PyYAML` dependency conflict with the Renode (see the GH issue #145).

If the AWS command line tool is necessary in the future, look into
either migrating to the `awscliv2` or installing the `awscli` package
in a virtual environment.

Signed-off-by: Stephanos Ioannidis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanosio stephanosio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dockerfile: Remove awscli Python package stephanosio/zephyr-docker-image
3 participants
@knthm @stephanosio @avolkov-1221