Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong macro on nullable value #2186

Closed
Jeckerson opened this issue Apr 4, 2021 · 0 comments · Fixed by #2197
Closed

Wrong macro on nullable value #2186

Jeckerson opened this issue Apr 4, 2021 · 0 comments · Fixed by #2197
Assignees
@Jeckerson
Labels
bug
Milestone
0.13.2

Comments

@Jeckerson
Copy link
Member

After this fix was merged - #2180
Now it seems that there are still situations when Zephir try to compare null value as a string.

Example:

public function setStatusCode(int code, string message = null) -> <ResponseInterface>

if message === null {

Produced C code:

if (ZEPHIR_IS_STRING_IDENTICAL(&message, "")) {
@Jeckerson Jeckerson added the bug label Apr 4, 2021
@Jeckerson Jeckerson added this to the 0.13.2 milestone Apr 4, 2021
@Jeckerson Jeckerson self-assigned this Apr 7, 2021
Jeckerson added a commit that referenced this issue Apr 7, 2021
@Jeckerson
#2186 - Add new operator ZEPHIR_IS_NULL
ef534d9
Jeckerson added a commit that referenced this issue Apr 7, 2021
@Jeckerson
#2186 - Add types in properties
6ea0c75
Jeckerson added a commit that referenced this issue Apr 7, 2021
@Jeckerson
#2186 - Add test case
4a224c4
Jeckerson added a commit that referenced this issue Apr 7, 2021
@Jeckerson
#2186 - Add IS_NULL check during string variable initialization
713506f
@Jeckerson Jeckerson mentioned this issue Apr 7, 2021
Merged
3 tasks
@Jeckerson Jeckerson linked a pull request Apr 7, 2021 that will close this issue
#2186 - Fix null strict check #2197
Merged
3 tasks
Jeckerson added a commit that referenced this issue Apr 7, 2021
@Jeckerson
#2186 - Update CHANGELOG.md
efbba3b
Jeckerson added a commit that referenced this issue Apr 7, 2021
@Jeckerson
#2186 - Fix zephir_get_strval macro
abdf616
Jeckerson added a commit that referenced this issue Apr 8, 2021
@Jeckerson
Merge branch 'development' into #2186-null-strict-check
ae55884
Jeckerson added a commit that referenced this issue Apr 8, 2021
@Jeckerson
Merge pull request #2197 from zephir-lang/#2186-null-strict-check
006b504 
#2186 - Fix `null` strict check
Jeckerson added a commit that referenced this issue Apr 9, 2021
@Jeckerson
#2186 - Change empty string check from IS_UNDEF to ZEPHIR_IS_EMPTY
1386bdc
@Jeckerson Jeckerson mentioned this issue Apr 9, 2021
Merged
3 tasks
AlexNDRmac added a commit that referenced this issue Apr 10, 2021
@AlexNDRmac
Merge pull request #2204 from zephir-lang/#2186-fix-seg-fault
3e6241b 
#2186 - Change empty string check from `IS_UNDEF` to `ZEPHIR_IS_EMPTY`
@Jeckerson Jeckerson mentioned this issue Apr 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeckerson Jeckerson

Labels
bug
Projects
None yet
Milestone
0.13.2
Development

Successfully merging a pull request may close this issue.

#2186 - Fix null strict check zephir-lang/zephir
1 participant
@Jeckerson