-
-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'void' return type hint is ignored #1908
Labels
Comments
I'm guessing stubs generations wasn't made when 7.1 was released, that's why we ignore void. I guess someone would need to update it and add check for php 7.1 |
JellyBrick
changed the title
'void' return type hint is ignored.
'void' return type hint is ignored
Aug 23, 2019
JellyBrick
added a commit
to organization/RapidPM
that referenced
this issue
Aug 24, 2019
JellyBrick
added a commit
to organization/RapidPM
that referenced
this issue
Aug 25, 2019
JellyBrick
added a commit
to organization/zephir
that referenced
this issue
Aug 25, 2019
sergeyklay
added a commit
that referenced
this issue
Sep 6, 2019
dreamsxin
pushed a commit
to dreamsxin/zephir
that referenced
this issue
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Log
Fatal error: Declaration of Pocketmine\Utils\BinaryStream::setOffset(int $offset) must be compatible with pocketmine\network\mcpe\protocol\Packet::setOffset(int $offset): void in /develop/pocketmine/src/network/mcpe/protocol/DataPacket.php on line 38
Code
Packet.php
DataPacket.php
binarystream.zep
However, the generated code has no type hints.
(Stubs included)
binarystream.zep stub
The text was updated successfully, but these errors were encountered: