This repository has been archived by the owner on Nov 10, 2020. It is now read-only.
Fix the bug that heartbeat ping not working properly #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this bug when I use modified surgemq in a emulator to profiling GoQuic with respect to TCP. (It has been a dozen of days since I do this modification so I forgot some details...)
The bug is functiuon processAcked(ackq *sessions.Ackqueue) in "process.go" will always try to decode the MsgBuf and will always fail on Ping/PingAck message because it is not given one during initialization. The high level code can not get any pingback semantic though the low level code actually send PING.
I fix this by attach a msgBuf with the message.