CommandTaskRunner: reset SHELL_VERBOSITY to pre-run state
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
force-pushed
the
application-shell-verbosity
branch
from
a955f57 to
6d349d2
Compare
Application::run() sets the SHELL_VERBOSITY environment variable globally. This causes subsequent tasks run in the same process to use this new value. This could lead to unexpected consequences (more log data than expected). This change captures the variable before running the command and resets it to this starting state after.
kbond
force-pushed
the
application-shell-verbosity
branch
from
6d349d2 to
58df54e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application::run()sets theSHELL_VERBOSITYenvironment variable globally. This causes subsequent tasks run in the same process to use this new value. This could lead to unexpected consequences (more log data than expected). This change captures the variable before running the command and resets it to this starting state after.