Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the function
getSymbol()
can return a different result in the different context if there was a polyfill.I ran into this exception when used
zen-observable
withfirebase@>5.0.3
.zen-observable/src/Observable.js
Line 441 in b9b7fa7
Because this line returns a wrong result:
zen-observable/src/Observable.js
Line 399 in b9b7fa7
It's different with the key defined at:
zen-observable/src/Observable.js
Line 391 in b9b7fa7
This PR is for internal changes, and can make other developer can live easier. 😄
Linked firebase issues: firebase/firebase-js-sdk#871 (comment)