Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Symbol): Conflictive polyfill #53

Merged

Conversation

giautm
Copy link
Contributor

@giautm giautm commented Oct 17, 2018

the function getSymbol() can return a different result in the different context if there was a polyfill.

I ran into this exception when used zen-observable with firebase@>5.0.3.

throw new TypeError(x + ' is not observable');

Because this line returns a wrong result:

let method = getMethod(x, getSymbol('observable'));

It's different with the key defined at:

[getSymbol('observable')]() { return this }

This PR is for internal changes, and can make other developer can live easier. 😄

Linked firebase issues: firebase/firebase-js-sdk#871 (comment)

@giautm
Copy link
Contributor Author

giautm commented Oct 19, 2018

@zenparsing : Sorry, can you review this PR?

@zenparsing zenparsing merged commit dc47a21 into zenparsing:master Oct 19, 2018
@zenparsing
Copy link
Owner

Published in 0.8.10. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants