Support more HTML input types. Close #800 #808
Merged
+95
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obetomuniz
force-pushed
the
feat/support-more-input-types
branch
from
055b664
to
c16f99a
Compare
helderberto
reviewed
May 3, 2022
test/actions/copy.js
Outdated
| @@ -51,5 +51,19 @@ describe('ClipboardActionCopy', () => { | |||
|
|
|||
| assert.equal(selectedText, text); | |||
| }); | |||
|
|
|||
| it.only('should select its value based on text', () => { | |||
There was a problem hiding this comment.
Just remember to remove the it.only.
helderberto
requested changes
May 3, 2022
helderberto
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If adding a new feature, the PR's description includes:
Other information:
This PR introduces a logical way to support HTML input types that don't have native support for the setSelectionRange API. This built-in support was initially requested in #800.
As an initial proposal, while reviewing the code, try to also think if makes sense to support it as an internal capability of the library.
For me, add this internally makes sense once it improves the developer experience abstracting business logic to support a default user behavior that allows the user to copy input values without concern about the type.