Prettier v3 の全面的な導入と VSCode の設定 #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
このPRには CI でのチェックが含まれていませんが、それも実装したほうが良ければ実装します。 |
senkenn
force-pushed
the
senkenn/issue#501
branch
from
eca1d4c
to
d86ec66
Compare
senkenn
force-pushed
the
senkenn/issue#501
branch
from
d86ec66
to
f15a55a
Compare
cm-igarashi-ryosuke
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
ご対応ありがとうございます！貢献に感謝します！
このPRの内容についてはLGTMです！他のPRをマージすることで、いくつかコンフリクトが発生すると思いますのでそこだけご対応をお願いします 🙇
その他、今後対応したいことを別のissueにしておきました。もし関心ありましたら引き続きご対応いただけると嬉しいです。
#506
|
@cm-igarashi-ryosuke コンフリクト解消しました！ |
cm-igarashi-ryosuke
approved these changes
Aug 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
.vscode/extensions.jsonで 推奨拡張機能の設定.vscode/settings.json各言語の設定packages/zenn-content-css/test.htmlでの変更量が大きすぎたので設定を見送った*foo bar*が_foo bar_に置き換わってしまったりと予期しない変更が入りそうだったので見送った（一応
_foo bar_でも正しくプレビューできているようではあるが、、）Resolves #501
📋 Tasks
プルリクエストを作成いただく際、お手数ですが以下の内容についてご確認をお願いします。
canaryブランチに対するプルリクエストであるより詳しい内容は Pull Request Policy を参照してください。