-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Metadata handling #3096
Conversation
…nto feature/better-metadata
Classification template updates in |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…nto feature/better-metadata
…nto feature/better-metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A more general comment: Do you think it makes sense to remove these run_metadata
attributes on all the responses to just metadata
? Especially run.run_metadata
seems very weird, and now that we're already breaking this by changing the type, might be a good opportunity to take a look at the names as well?
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
🦭 |
Describe changes
The fact that run metadata is stored in a separate table with a row per key-value pair is business logic. I don't see the benefit of exposing this to the user/client. As a user when I run model_version.run_metadata i expect to get a simple
metadata dictionary, instead I get a fulminant RunMetadataResponseBody.
On top of that, the run_metadata lead to bloating of the api response sizes.
Example response body:
response_1729171061701.json
Time to list 100 hydrated model versions with the state on develop:
Time to list 100 hydrated model versions after this change:
Breaking Change
All code that accesses run_metadata now needs to be changed:
-->
Metadata is now a familiar python dictionary.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes