-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor environment setup and caching #3077
Conversation
LLM Finetuning template updates in |
Classification template updates in |
E2E template updates in |
…enml into misc/improve-ci-cache
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
3584396 | Triggered | Generic Password | 0903f65 | .github/workflows/integration-test-fast.yml | View secret |
3584396 | Triggered | Generic Password | a712dcf | .github/workflows/integration-test-fast.yml | View secret |
3584396 | Triggered | Generic Password | a712dcf | .github/workflows/integration-test-fast.yml | View secret |
3584396 | Triggered | Generic Password | 449fe79 | .github/workflows/integration-test-fast.yml | View secret |
3584396 | Triggered | Generic Password | e6e729d | .github/workflows/integration-test-fast.yml | View secret |
3584396 | Triggered | Generic Password | e6e729d | .github/workflows/integration-test-fast.yml | View secret |
3584396 | Triggered | Generic Password | 21378cf | .github/workflows/integration-test-fast.yml | View secret |
3584396 | Triggered | Generic Password | f6b4d69 | .github/workflows/integration-test-fast.yml | View secret |
3584396 | Triggered | Generic Password | f6b4d69 | .github/workflows/integration-test-fast-services.yml | View secret |
3584396 | Triggered | Generic Password | 6a55f93 | .github/workflows/integration-test-fast-services.yml | View secret |
3584396 | Triggered | Generic Password | de88ae4 | .github/workflows/integration-test-fast-services.yml | View secret |
3584396 | Triggered | Generic Password | 1d0bc0b | .github/workflows/integration-test-slow-services.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…egistry credentials
…egistry credentials
…-docker-orchestrator environment
E2E template updates in |
NLP template updates in |
LLM Finetuning template updates in |
Classification template updates in |
E2E template updates in |
NLP template updates in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few more comments and there were a few open still.
Describe changes
I implemented/fixed _ to achieve _.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes
Summary by CodeRabbit
New Features
github-actions-server-docker-orchestrator
added.Bug Fixes
mlflow
package to prevent compatibility issues.Documentation
Chores