Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor environment setup and caching #3077

Merged
merged 71 commits into from
Nov 8, 2024
Merged

Conversation

safoinme
Copy link
Contributor

@safoinme safoinme commented Oct 13, 2024

Describe changes

I implemented/fixed _ to achieve _.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

Summary by CodeRabbit

  • New Features

    • Introduced new workflows for integration tests and linting, enhancing testing capabilities across different environments.
    • Added a new deployment configuration for a ZenML server to support GitHub Actions.
    • New environment configuration for github-actions-server-docker-orchestrator added.
  • Bug Fixes

    • Updated version constraints for the mlflow package to prevent compatibility issues.
  • Documentation

    • Enhanced input options and descriptions for improved user interaction in workflows.
  • Chores

    • Updated workflow environments to standardize execution across jobs.

@github-actions github-actions bot added the internal To filter out internal PRs and issues label Oct 13, 2024
Copy link
Contributor

LLM Finetuning template updates in examples/llm_finetuning have been pushed.

Copy link
Contributor

Classification template updates in examples/mlops_starter have been pushed.

Copy link
Contributor

E2E template updates in examples/e2e have been pushed.

Copy link

gitguardian bot commented Oct 14, 2024

⚠️ GitGuardian has uncovered 12 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
3584396 Triggered Generic Password 0903f65 .github/workflows/integration-test-fast.yml View secret
3584396 Triggered Generic Password a712dcf .github/workflows/integration-test-fast.yml View secret
3584396 Triggered Generic Password a712dcf .github/workflows/integration-test-fast.yml View secret
3584396 Triggered Generic Password 449fe79 .github/workflows/integration-test-fast.yml View secret
3584396 Triggered Generic Password e6e729d .github/workflows/integration-test-fast.yml View secret
3584396 Triggered Generic Password e6e729d .github/workflows/integration-test-fast.yml View secret
3584396 Triggered Generic Password 21378cf .github/workflows/integration-test-fast.yml View secret
3584396 Triggered Generic Password f6b4d69 .github/workflows/integration-test-fast.yml View secret
3584396 Triggered Generic Password f6b4d69 .github/workflows/integration-test-fast-services.yml View secret
3584396 Triggered Generic Password 6a55f93 .github/workflows/integration-test-fast-services.yml View secret
3584396 Triggered Generic Password de88ae4 .github/workflows/integration-test-fast-services.yml View secret
3584396 Triggered Generic Password 1d0bc0b .github/workflows/integration-test-slow-services.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

E2E template updates in examples/e2e have been pushed.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

NLP template updates in examples/e2e_nlp have been pushed.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

LLM Finetuning template updates in examples/llm_finetuning have been pushed.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Classification template updates in examples/mlops_starter have been pushed.

.github/workflows/ci-fast.yml Outdated Show resolved Hide resolved
.github/workflows/ci-slow.yml Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Nov 7, 2024

E2E template updates in examples/e2e have been pushed.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

NLP template updates in examples/e2e_nlp have been pushed.

Copy link
Contributor

@bcdurak bcdurak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few more comments and there were a few open still.

.github/workflows/ci-slow.yml Show resolved Hide resolved
.github/workflows/ci-fast.yml Show resolved Hide resolved
.github/workflows/ci-slow.yml Outdated Show resolved Hide resolved
@safoinme safoinme requested a review from bcdurak November 8, 2024 09:47
@safoinme safoinme merged commit cc9c3d8 into develop Nov 8, 2024
24 of 34 checks passed
@safoinme safoinme deleted the misc/improve-ci-cache branch November 8, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal To filter out internal PRs and issues run-slow-ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants