Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register_artifact function #3053

Merged
merged 30 commits into from
Oct 10, 2024
Merged

Conversation

avishniakov
Copy link
Contributor

@avishniakov avishniakov commented Oct 4, 2024

Describe changes

I implemented register_artifact function to support use-cases when users want to just link already existing data inside the artifact store scope manually saved by some other tools.

Docs section has quite some examples of the usage in various scenarios.

Example use-case: Pytorch-Lightning has the ability to store checkpoints on a given remote storage, so there is no need to do save_artifact in the end epoch callback or similar, but rather just link existing checkpoint to be available as a ZenML artifact for the future use.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

Copy link
Contributor

coderabbitai bot commented Oct 4, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Oct 4, 2024
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments as most people are out today :-)

docs/book/user-guide/starter-guide/manage-artifacts.md Outdated Show resolved Hide resolved
docs/book/user-guide/starter-guide/manage-artifacts.md Outdated Show resolved Hide resolved
@avishniakov
Copy link
Contributor Author

@wjayesh since we had a word about this on Discord, you might want to look into this before we merge as well.

@avishniakov avishniakov changed the title link_folder_as_artifact function link_existing_data_as_artifact function Oct 7, 2024
src/zenml/artifacts/utils.py Show resolved Hide resolved
src/zenml/artifacts/load_directory_materializer.py Outdated Show resolved Hide resolved
src/zenml/artifacts/load_directory_materializer.py Outdated Show resolved Hide resolved
src/zenml/artifacts/utils.py Outdated Show resolved Hide resolved
@avishniakov avishniakov changed the title link_existing_data_as_artifact function register_artifact function Oct 8, 2024
@avishniakov
Copy link
Contributor Author

avishniakov commented Oct 8, 2024

@htahir1 would need your 🦭 to merge this sometime

Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor do overs but almost there

Copy link
Contributor

@bcdurak bcdurak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments as well.

src/zenml/artifacts/utils.py Show resolved Hide resolved
docs/book/user-guide/starter-guide/manage-artifacts.md Outdated Show resolved Hide resolved
docs/book/user-guide/starter-guide/manage-artifacts.md Outdated Show resolved Hide resolved
src/zenml/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! but consider it approved from my side once you apply final changes :-) Great job!

docs/book/user-guide/starter-guide/manage-artifacts.md Outdated Show resolved Hide resolved
src/zenml/__init__.py Outdated Show resolved Hide resolved
src/zenml/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Oct 9, 2024

E2E template updates in examples/e2e have been pushed.

@avishniakov avishniakov merged commit 74b0d47 into develop Oct 10, 2024
7 checks passed
@avishniakov avishniakov deleted the feature/PRD-659-link-data-as-artifact branch October 10, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal To filter out internal PRs and issues run-slow-ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants