-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
register_artifact
function
#3053
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments as most people are out today :-)
@wjayesh since we had a word about this on Discord, you might want to look into this before we merge as well. |
link_folder_as_artifact
functionlink_existing_data_as_artifact
function
link_existing_data_as_artifact
functionregister_artifact
function
@htahir1 would need your 🦭 to merge this sometime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor do overs but almost there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! but consider it approved from my side once you apply final changes :-) Great job!
Co-authored-by: Hamza Tahir <[email protected]>
E2E template updates in |
Describe changes
I implemented
register_artifact
function to support use-cases when users want to just link already existing data inside the artifact store scope manually saved by some other tools.Docs section has quite some examples of the usage in various scenarios.
Example use-case: Pytorch-Lightning has the ability to store checkpoints on a given remote storage, so there is no need to do
save_artifact
in the end epoch callback or similar, but rather just link existing checkpoint to be available as a ZenML artifact for the future use.Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes