Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency cleanup and Python 3.12 support #2953
Dependency cleanup and Python 3.12 support #2953
Changes from all commits
3f8c142
b24a0ec
91d4446
7428594
7ea24e0
651c78f
999f41f
b393d76
c5ef3aa
87f81b7
c36b4b2
20a0558
4fe85b0
b7142a1
786db93
d43f47e
e93f0ea
645022f
6e78cc4
745c133
a86b46b
a740017
5b4d254
5eba9db
175b012
5edd731
e931ed0
4fa0f52
1b0467e
ec28644
e3258ba
f5b3925
dbbff16
17d23e6
5573ff1
c4bb7ff
0fc920e
91b3862
376619d
3d97e52
e7aa9dc
d8b1405
51dc15e
d16263a
6804f90
d495ce4
301247a
6f3a2f9
2e8e293
bda0fc5
9ecb49d
a4cfb23
813951f
3f2cbe4
d2a70c8
e936c84
2b35bfa
ed251d0
7270ec9
4ff045e
818fc59
dfc1a1c
ed3d07b
d82eabe
30e937f
fad1fdf
0122856
a115d88
6b80504
ae5589a
265596a
5eb5359
2823f67
51b48cd
6ab7e59
6bfcd59
f3b0e7d
5235b5d
98c92b3
fd356de
5631c04
d0fc578
1ca2bf1
9d95530
3d4a328
5102cbd
b2ec5be
ce96a0f
a573668
61ec239
b486e67
cb6623f
4c6a5d7
81d5c40
f9e951c
d3dad36
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remember to remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the reminder. I had to add one more of this to the
small-checks
workflow in the CI, unfortunately. We have to keep them until we can release a new version ofmlstacks
. I will keep this thread unresolved as a reminder to myself.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stefannica Just so you know, this is going to be a bit tricky as I can not remove these lines with this PR.
Right now, the changes that I made are not compatible with the latest release of
mlstacks
(0.9.0). If I remove them now and merge todevelop
, all the subsequent CI runs on other PRs branching off ofdevelop
will fail.We can potentially release a new version of
mlstacks
as a solution but if we do thatmlstacks
will be broken until we release a new version ofzenml
. (There won't be anyzenml
versions which can work with this newmlstacks
release.)So, my proposal would be something like this:
install-zenml-dev
andsmall-checks
pointing to my upgrade branch on themlstacks
repo.zenml
, we do themlstacks
release, merge the PR from point 2 and proceed with the release.This needs to be communicated to the product team as well, I will take over that.