Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only login to docker for PRs with secret access #2842

Merged
merged 1 commit into from
Jul 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci-slow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ jobs:
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
if: github.event.pull_request.head.repo.fork == false
- name: Test migrations across versions
run: bash scripts/test-migrations.sh mysql full
mysql-db-migration-testing-random:
Expand All @@ -98,6 +99,7 @@ jobs:
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
if: github.event.pull_request.head.repo.fork == false
- name: Test migrations across versions
run: bash scripts/test-migrations.sh mysql random
sqlite-db-migration-testing-full:
Expand Down Expand Up @@ -138,6 +140,7 @@ jobs:
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
if: github.event.pull_request.head.repo.fork == false
- name: Test migrations across versions
run: bash scripts/test-migrations.sh mariadb full
small-checks:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/integration-test-fast.yml
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,9 @@ jobs:
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
if: contains(inputs.test_environment, 'docker') || contains(inputs.test_environment,
'kubeflow') || contains(inputs.test_environment, 'airflow') || contains(inputs.test_environment,
'kubernetes')
if: github.event.pull_request.head.repo.fork == false && (contains(inputs.test_environment,
'docker') || contains(inputs.test_environment, 'kubeflow') || contains(inputs.test_environment,
'airflow') || contains(inputs.test_environment, 'kubernetes'))
- name: Setup environment
uses: ./.github/actions/setup_environment
with:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/integration-test-slow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,9 @@ jobs:
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
if: contains(inputs.test_environment, 'docker') || contains(inputs.test_environment,
'kubeflow') || contains(inputs.test_environment, 'airflow') || contains(inputs.test_environment,
'kubernetes')
if: github.event.pull_request.head.repo.fork == false && (contains(inputs.test_environment,
'docker') || contains(inputs.test_environment, 'kubeflow') || contains(inputs.test_environment,
'airflow') || contains(inputs.test_environment, 'kubernetes'))
- uses: actions/[email protected]
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1
Expand Down
Loading