Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kfp version in GCP integration for pydantic2.0 #2824

Merged
merged 2 commits into from
Jul 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions examples/llm_finetuning/steps/finetune.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,12 @@ def finetune(
if should_print:
logger.info("Loading datasets...")
tokenizer = load_tokenizer(base_model_id, use_fast=use_fast)
tokenized_train_dataset = load_from_disk(dataset_dir / "train")
tokenized_val_dataset = load_from_disk(dataset_dir / "val")
tokenized_train_dataset = load_from_disk(
str((dataset_dir / "train").absolute())
)
tokenized_val_dataset = load_from_disk(
str((dataset_dir / "val").absolute())
)

if should_print:
logger.info("Loading base model...")
Expand Down Expand Up @@ -162,7 +166,6 @@ def finetune(
if should_print:
logger.info("Saving model...")

ft_model_dir = Path(ft_model_dir)
if not use_accelerate or accelerator.is_main_process:
ft_model_dir.mkdir(parents=True, exist_ok=True)
if not use_accelerate:
Expand Down
2 changes: 1 addition & 1 deletion src/zenml/integrations/gcp/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class GcpIntegration(Integration):

NAME = GCP
REQUIREMENTS = [
"kfp>=1.8.22",
"kfp>=2.6.0",
"gcsfs",
"google-cloud-secret-manager",
"google-cloud-container>=2.21.0",
Expand Down