Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HELM] Remove extra environment variable assignment #2518

Merged
merged 1 commit into from
Mar 13, 2024
Merged

[HELM] Remove extra environment variable assignment #2518

merged 1 commit into from
Mar 13, 2024

Conversation

wjayesh
Copy link
Contributor

@wjayesh wjayesh commented Mar 13, 2024

Describe changes

I fixed the helm chart to no longer assign the ZENML_SERVER_BASE_URL variable twice, which leads to errors when upgrading.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added the internal To filter out internal PRs and issues label Mar 13, 2024
@stefannica stefannica merged commit eea0788 into develop Mar 13, 2024
37 of 38 checks passed
@stefannica stefannica deleted the fix/duplicate-env-helm-chart branch March 13, 2024 07:59
AlexejPenner pushed a commit that referenced this pull request Mar 18, 2024
@wjayesh @AlexejPenner
remove extra env var assignment (#2518)
ce8cdb3
adtygan pushed a commit to adtygan/zenml that referenced this pull request Mar 21, 2024
@wjayesh @adtygan
remove extra env var assignment (zenml-io#2518)
ba9ca1b
AlexejPenner added a commit that referenced this pull request Mar 26, 2024
@AlexejPenner @bcdurak
@safoinme @actions-user @stefannica @strickvl @coderabbitai @wjayesh @schustmi
Interact with feature gate (#2492)
5406fa7 
* Interact with feature gate

* Properly handle entitlement violations

* Apply suggestions from code review

Co-authored-by: Barış Can Durak <[email protected]>
Co-authored-by: Safoine El Khabich <[email protected]>

* Auto-update of Starter template

* Applied code reviews

* reformatted

* Reformatted

* Disable feature_gate when no source specified.

* Auto-update of Starter template

* Auto-update of E2E template

* Auto-update of NLP template

* Handle corrupted or empty global configuration file (#2508)

* Handle corrupted or empty global configuration file

* Auto-update of Starter template

---------

Co-authored-by: GitHub Actions <[email protected]>

* Linted

* Add admin users notion (#2494)

* add admin users to OSS

* skip missing methods

* increase readability

* doc string

* lint

* lint

* missing arg

* add some edge-cases

* wip commit to carve out clean_client changes

* revert irrelevant changes

* revert irrelevant changes

* rework tests to run on rest

* Apply suggestions from code review

Co-authored-by: Alex Strick van Linschoten <[email protected]>
Co-authored-by: Stefan Nica <[email protected]>

* polish test cases

* fix branching

* admin user mgmt CLI/Client

* close activation vulnerability

* revert rbac changes

* verify admin permissions in endpoints

* add `is_admin` to external users

* only reg users will be migrated as admins

* default is always admin

* extend tests

* lint

* default `is_admin` None

* Auto-update of Starter template

* review suggestions

* review suggestions

* calm down linter

* Update src/zenml/cli/user_management.py

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Alex Strick van Linschoten <[email protected]>

* review suggestion

---------

Co-authored-by: Alex Strick van Linschoten <[email protected]>
Co-authored-by: Stefan Nica <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* remove dashboard from gitignore (#2517)

* Colima / Homebrew fix (#2512)

* attempt fix

* Auto-update of Starter template

* colima qemu fix trial

* remove qemu

* logs

* logs better

* testing brew workaround

* try second possible fix for python gha

* actually apply the fix

* try the second possible solution for unbreaking python

* make the CI whole again

* linting

* fix python 3.11 on mac (test)

* one more attempt

* formatting

* different fix

* restore the CI to full glory (fixed now!)

---------

Co-authored-by: GitHub Actions <[email protected]>

* remove extra env var assignment (#2518)

* Allow installing packages using UV (#2510)

* Allow installing packages using UV

* Auto-update of Starter template

* actually make it work

* Auto-update of Starter template

---------

Co-authored-by: GitHub Actions <[email protected]>

* Additional fields for track events (#2507)

* additional fields for track events

* formatting

* Auto-update of Starter template

* adding a few recommendations

* formatting

* Auto-update of Starter template

---------

Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: Alex Strick van Linschoten <[email protected]>

* Auto-update of Starter template

* Auto-update of NLP template

* Auto-update of E2E template

* Update src/zenml/zen_server/exceptions.py

Co-authored-by: Stefan Nica <[email protected]>

* Update src/zenml/zen_server/cloud_utils.py

Co-authored-by: Stefan Nica <[email protected]>

* Applied code review.

* Properly reformatted

* Reformatted

* Fixed test

* Fixed docstring

* Model deletion works now, fixed error message

* Show correct error message when creating models that exceed subscription limit

* Send resource id

* Auto-update of LLM Finetuning template

* Fix error

* Limit pipeline namespaces

* Remove billing url

* Linted

* Potential fix

---------

Co-authored-by: Barış Can Durak <[email protected]>
Co-authored-by: Safoine El Khabich <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: Stefan Nica <[email protected]>
Co-authored-by: Alex Strick van Linschoten <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Jayesh Sharma <[email protected]>
Co-authored-by: Michael Schuster <[email protected]>
Co-authored-by: Michael Schuster <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefannica stefannica stefannica approved these changes

Assignees
No one assigned
Labels
internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjayesh @stefannica