Log URL for pipelines and model versions when running a pipeline #2506

wjayesh · 2024-03-08T14:06:18Z

Describe changes

I implemented a get_model_version_url to construct the URL for a model version inside dashboard utils.
Updated the get_base_url function to use the URL from server configuration if it's set.
Log pipeline URL before it is run.

Pre-requisites

Please ensure you have done the following:

I have read the CONTRIBUTING.md document.
If my change requires a change to docs, I have updated the documentation accordingly.
I have added tests to cover my changes.
I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Other (add details above)

coderabbitai · 2024-03-08T14:06:23Z

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

src/zenml/model/model.py

Co-authored-by: Andrei Vishniakov <[email protected]>

src/zenml/utils/dashboard_utils.py

avishniakov

Smells like a circular dep, based on the CI output

wjayesh · 2024-03-13T03:28:26Z

~~Hmm, I can't seem to figure out why that's happening. Let me take a deeper look~~

github-actions · 2024-03-14T01:41:13Z

Quickstart template updates in examples/quickstart have been pushed.

src/zenml/model/model.py

src/zenml/new/pipelines/pipeline.py

src/zenml/model/model.py

avishniakov

All good, one small suggestion.

src/zenml/new/pipelines/run_utils.py

src/zenml/model/model.py

…ub.com/zenml-io/zenml into feature/log-cloud-urls-pipeline-models

schustmi

LGTM, thanks for the adjustments!

…ml-io#2506) * add model url function and use config's base url * attach model version URL with model creation log * output url of pipeline in dashboard before deploying it * only display model URL for cloud * log model url for new and existing models Co-authored-by: Andrei Vishniakov <[email protected]> * don't add workspace in cloud url * small embellishment * attempt to fix circular import * Auto-update of Starter template * format files * fix function arg type * fix loading of config * change where model URL is logged * linting * improve logging message and log non cloud case only once * fix docstring * make cloud check more robust * move cloud functions to new cloud utils * fix linter and docstring --------- Co-authored-by: Andrei Vishniakov <[email protected]> Co-authored-by: GitHub Actions <[email protected]>

wjayesh added 4 commits March 7, 2024 17:34

add model url function and use config's base url

ae8d643

attach model version URL with model creation log

2760d30

output url of pipeline in dashboard before deploying it

1478416

only display model URL for cloud

255cbb2

github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Mar 8, 2024

strickvl requested a review from avishniakov March 8, 2024 14:07

wjayesh requested a review from schustmi March 11, 2024 07:16

avishniakov reviewed Mar 11, 2024

View reviewed changes

src/zenml/model/model.py Outdated Show resolved Hide resolved

log model url for new and existing models

5b59a58

Co-authored-by: Andrei Vishniakov <[email protected]>

schustmi requested changes Mar 11, 2024

View reviewed changes

src/zenml/utils/dashboard_utils.py Outdated Show resolved Hide resolved

don't add workspace in cloud url

718a007

wjayesh requested review from avishniakov and schustmi March 12, 2024 09:59

avishniakov requested changes Mar 12, 2024

View reviewed changes

small embellishment

270afb3

wjayesh and others added 2 commits March 13, 2024 23:16

attempt to fix circular import

a7d0cbe

Auto-update of Starter template

afe3777

wjayesh added 2 commits March 14, 2024 11:39

format files

610fc72

fix function arg type

4b317ed

wjayesh added the run-slow-ci label Mar 14, 2024

wjayesh added 3 commits March 15, 2024 10:06

fix loading of config

12ceb5b

change where model URL is logged

4358fe3

linting

40db7aa

wjayesh requested a review from avishniakov March 15, 2024 08:10

Merge branch 'develop' into feature/log-cloud-urls-pipeline-models

1bfe3e4

avishniakov requested changes Mar 15, 2024

View reviewed changes

src/zenml/model/model.py Outdated Show resolved Hide resolved

src/zenml/new/pipelines/pipeline.py Show resolved Hide resolved

src/zenml/model/model.py Outdated Show resolved Hide resolved

src/zenml/model/model.py Outdated Show resolved Hide resolved

wjayesh added 2 commits March 15, 2024 16:25

improve logging message and log non cloud case only once

dc15cff

fix docstring

31b57d0

wjayesh requested a review from avishniakov March 15, 2024 13:04

avishniakov approved these changes Mar 15, 2024

View reviewed changes

src/zenml/new/pipelines/run_utils.py Outdated Show resolved Hide resolved

wjayesh added 2 commits March 18, 2024 10:32

make cloud check more robust

636ded5

Merge branch 'develop' into feature/log-cloud-urls-pipeline-models

cb1e523

schustmi requested changes Mar 18, 2024

View reviewed changes

src/zenml/model/model.py Outdated Show resolved Hide resolved

wjayesh added 5 commits March 18, 2024 14:23

move cloud functions to new cloud utils

e301d03

Merge branch 'feature/log-cloud-urls-pipeline-models' of https://gith…

7952638

…ub.com/zenml-io/zenml into feature/log-cloud-urls-pipeline-models

Merge branch 'develop' into feature/log-cloud-urls-pipeline-models

dc1eb14

fix linter and docstring

131dab0

Merge branch 'feature/log-cloud-urls-pipeline-models' of https://gith…

cde6e6f

…ub.com/zenml-io/zenml into feature/log-cloud-urls-pipeline-models

wjayesh requested a review from schustmi March 19, 2024 03:33

schustmi approved these changes Mar 19, 2024

View reviewed changes

wjayesh merged commit 332eab7 into develop Mar 19, 2024
54 of 56 checks passed

wjayesh deleted the feature/log-cloud-urls-pipeline-models branch March 19, 2024 07:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Log URL for pipelines and model versions when running a pipeline #2506

Log URL for pipelines and model versions when running a pipeline #2506

wjayesh commented Mar 8, 2024

coderabbitai bot commented Mar 8, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

avishniakov left a comment

wjayesh commented Mar 13, 2024 •

edited

Loading

github-actions bot commented Mar 14, 2024

avishniakov left a comment

schustmi left a comment

Log URL for pipelines and model versions when running a pipeline #2506

Log URL for pipelines and model versions when running a pipeline #2506

Conversation

wjayesh commented Mar 8, 2024

Describe changes

Pre-requisites

Types of changes

coderabbitai bot commented Mar 8, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

avishniakov left a comment

Choose a reason for hiding this comment

wjayesh commented Mar 13, 2024 • edited Loading

github-actions bot commented Mar 14, 2024

avishniakov left a comment

Choose a reason for hiding this comment

schustmi left a comment

Choose a reason for hiding this comment

CodeRabbit Configration File (`.coderabbit.yaml`)

wjayesh commented Mar 13, 2024 •

edited

Loading