-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniquely constrained users table #2483
Uniquely constrained users table #2483
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the WalkthroughThe update introduces a unique constraint to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@coderabbitai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 4
Configuration used: .coderabbit.yaml
Files selected for processing (3)
- src/zenml/zen_stores/migrations/versions/72675226b2de_unique_users.py (1 hunks)
- src/zenml/zen_stores/schemas/user_schemas.py (2 hunks)
- src/zenml/zen_stores/sql_zen_store.py (2 hunks)
Additional comments: 1
src/zenml/zen_stores/schemas/user_schemas.py (1)
- 68-68: The addition of the
UniqueConstraint
on the "name" and "is_service_account" columns in theUserSchema
class is correctly implemented and aligns with the PR's objectives to prevent duplicate user entries. This change complements the database-level constraint added by the migration script and is a good practice for enforcing data integrity at both the ORM and database levels.
src/zenml/zen_stores/migrations/versions/72675226b2de_unique_users.py
Outdated
Show resolved
Hide resolved
src/zenml/zen_stores/migrations/versions/72675226b2de_unique_users.py
Outdated
Show resolved
Hide resolved
Quickstart template updates in |
NLP template updates in |
Quickstart template updates in |
NLP template updates in |
* use db constrains for users * lint a bit * coderabbitai * set rate limits for login api * Revert "set rate limits for login api" This reverts commit 78ce40e. * bring checks back * Auto-update of Starter template * Auto-update of NLP template * review suggestions * resolve branching * Auto-update of Starter template * Auto-update of NLP template * lint --------- Co-authored-by: GitHub Actions <[email protected]>
Describe changes
I fixed how we ensure that no duplicates are passed to the DB level for UserSchema.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes
Summary by CodeRabbit