Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniquely constrained users table #2483

Merged
merged 15 commits into from
Mar 4, 2024

Conversation

avishniakov
Copy link
Contributor

@avishniakov avishniakov commented Feb 29, 2024

Describe changes

I fixed how we ensure that no duplicates are passed to the DB level for UserSchema.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

Summary by CodeRabbit

  • New Features
    • Implemented a unique constraint for user names to ensure each user is distinct, enhancing data integrity.
  • Refactor
    • Improved transaction management with better exception handling for user creation and updates.

Copy link
Contributor

coderabbitai bot commented Feb 29, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Walkthrough

The update introduces a unique constraint to the user table, ensuring that each combination of user name and service account status is unique. It modifies the schema to include this constraint and enhances the transaction management in the SQL store. Exception handling is improved with specific attention to IntegrityError, streamlining the process of checking for existing entities before their creation.

Changes

File Path Change Summary
.../migrations/versions/72675226b2de_unique_users.py Adds a migration script for unique constraint on user table.
.../zen_stores/schemas/user_schemas.py Introduces UniqueConstraint in UserSchema.
.../zen_stores/sql_zen_store.py Enhances transaction management and exception handling for entity creation.

🐇✨
To the database, we hop and bound,
With unique users, no duplicates found.
Try and catch, we gracefully manage,
Ensuring integrity, with no damage.
So here's to changes, both big and small,
May our code run smoothly, bugs none at all.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Feb 29, 2024
@avishniakov
Copy link
Contributor Author

@coderabbitai review

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 4

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 357f94c and 135c2e0.
Files selected for processing (3)
  • src/zenml/zen_stores/migrations/versions/72675226b2de_unique_users.py (1 hunks)
  • src/zenml/zen_stores/schemas/user_schemas.py (2 hunks)
  • src/zenml/zen_stores/sql_zen_store.py (2 hunks)
Additional comments: 1
src/zenml/zen_stores/schemas/user_schemas.py (1)
  • 68-68: The addition of the UniqueConstraint on the "name" and "is_service_account" columns in the UserSchema class is correctly implemented and aligns with the PR's objectives to prevent duplicate user entries. This change complements the database-level constraint added by the migration script and is a good practice for enforcing data integrity at both the ORM and database levels.

src/zenml/zen_stores/sql_zen_store.py Outdated Show resolved Hide resolved
src/zenml/zen_stores/sql_zen_store.py Outdated Show resolved Hide resolved
Copy link
Contributor

Quickstart template updates in examples/quickstart have been pushed.

Copy link
Contributor

NLP template updates in examples/e2e_nlp have been pushed.

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Quickstart template updates in examples/quickstart have been pushed.

Copy link
Contributor

github-actions bot commented Mar 1, 2024

NLP template updates in examples/e2e_nlp have been pushed.

@avishniakov avishniakov merged commit afcaf74 into develop Mar 4, 2024
61 checks passed
@avishniakov avishniakov deleted the bugfix/OSSK-457-uniquely-constrained-users branch March 4, 2024 09:05
@stefannica stefannica mentioned this pull request Mar 8, 2024
1 task
adtygan pushed a commit to adtygan/zenml that referenced this pull request Mar 21, 2024
* use db constrains for users

* lint a bit

* coderabbitai

* set rate limits for login api

* Revert "set rate limits for login api"

This reverts commit 78ce40e.

* bring checks back

* Auto-update of Starter template

* Auto-update of NLP template

* review suggestions

* resolve branching

* Auto-update of Starter template

* Auto-update of NLP template

* lint

---------

Co-authored-by: GitHub Actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues run-slow-ci security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants