REVERTED: Allow more recent adlfs and s3fs versions
#2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughWalkthroughThe recent modifications involve loosening version constraints for dependencies in the ZenML Azure and S3 integrations. Specifically, the Azure integration now accepts any version of Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
strickvl
added
internal
strickvl
requested review from
stefannica,
safoinme and
bcdurak
and removed request for
stefannica
strickvl
changed the title
adlfs and s3fs versionsadlfs and s3fs versions
|
@coderabbitai review |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (2)
- src/zenml/integrations/azure/init.py (1 hunks)
- src/zenml/integrations/s3/init.py (1 hunks)
Additional comments: 2
src/zenml/integrations/s3/__init__.py (1)
- 45-45: The removal of the upper version constraint for
"s3fs"in theREQUIREMENTSlist aligns with the PR objectives. Ensure that this change has been tested to not introduce compatibility issues with the current or future versions ofs3fs.src/zenml/integrations/azure/__init__.py (1)
- 42-42: Changing the
adlfsrequirement to a minimum version requirement increases flexibility and future compatibility. Confirm that this change does not introduce any compatibility issues with the broader dependency tree, especially considering other fixed version dependencies listed.
|
It seems like pytorch_lightening is failing to be installed, is this tested already or just an attempt to let it find new matching versions? |
|
@safoinme this is to unlock the Huggingface Model Deployer (which is blocked by these two dependencies. Where do you see it's not installing PTLightning? It passes the full slow CI: https://github.com/zenml-io/zenml/actions/runs/7800110571 |
|
oh, that's nice, do you think unlocking those will enable whatever dependency is needed for the HF deployer without causing conflict for other dependencies? |
safoinme
approved these changes
Feb 7, 2024
|
I think we should probably test this a bit, but yeah that is the hope :) |
stefannica
approved these changes
Feb 12, 2024
bcdurak
approved these changes
Feb 12, 2024
|
Tested that running a simple pipeline using azure and s3 artifact stores work from the new versions / PR. |
strickvl
changed the title
adlfs and s3fs versionsadlfs and s3fs versions
|
This PR has now been completely reverted in #2440 |
strickvl
added a commit
that referenced
this pull request
Feb 19, 2024
* fixing update models * reverting the update model changes * linting * linting * revert #2402 * revert adlfs changes --------- Co-authored-by: Andrei Vishniakov <[email protected]> Co-authored-by: Alex Strick van Linschoten <[email protected]>
avishniakov
added a commit
that referenced
this pull request
Feb 21, 2024
* Fix conditional statements in GitHub workflows (#2404) * Fix conditional statements in GitHub workflows * rename core CI flows * slow CI check doesn't happen when draft * Auto-update of Starter template * fix double conditional --------- Co-authored-by: GitHub Actions <[email protected]> * Ensure proper spacing in error messages (#2399) * Ensure proper spacing in error messages * update TOC (#2406) --------- Co-authored-by: Alex Strick van Linschoten <[email protected]> * Fix hyperai markdown table (#2426) * build: ⬆️ Upgrade min required google-cloud-aiplatform to 1.34.0 (#2428) * Close code block left open in the docs (#2432) * Fix docs * wrong ticks! * Simplify HF example and notify when cache is down (#2300) * starter files for the new CI paradigm * disable fast/slow ci on base branch * disable core workflow * Fast/slow CI core scaffold (#2274) * give darglint check its own job * fastCI * add slowCI * reenable fast CI * remove comment * add integration tests * fix spellcheck context * enable slow CI for testing * remove unit test dependency * fix dependency installations * yamlfixed * Comment-driven CI (#2275) * test comment-driven approach * delete unused test file * slow CI is comment-driven * restore CI * conditionally respond to comments depending on team status * add the whole team * Update .github/workflows/ci-slow.yml Co-authored-by: Andrei Vishniakov <[email protected]> --------- Co-authored-by: Andrei Vishniakov <[email protected]> * delete old CI --------- Co-authored-by: Andrei Vishniakov <[email protected]> * remove spellcheck from slow CI * update spellcheck run conditions * Add GitHub issue creation on cache miss * test failing cache * Update Minio endpoint in setup_environment action.yml * Update minio-service endpoint in setup_environment action.yml * Sharded integration tests for Ubuntu (#2286) * add pytest-shard dev dependency * update script for sharded testing * add ubuntu sharding * fix naming * Use `pytest-split` to shard CI (#2296) * add split test to action * Update user authentication logic * Fix bug in login functionality * Refactor test coverage script * Update excluded directories in pyproject.toml * Update integration test script to include shard number * Update integration test script to use matrix.shard * Update caching key in setup_environment action.yml * Update durations path in test-coverage-xml.sh * Update cache key in setup_environment action.yml * Auto-update of Starter template * Fix formatting issue in setup_environment action.yml * Refactor code to improve performance and readability --------- Co-authored-by: GitHub Actions <[email protected]> * Update pyproject.toml Co-authored-by: Alex Strick van Linschoten <[email protected]> * add extra final line * make workflows use normal ubuntu) * fix durations path and update docstring --------- Co-authored-by: Safoine El Khabich <[email protected]> Co-authored-by: GitHub Actions <[email protected]> * Auto-update of Starter template * Auto-update of NLP template * Auto-update of E2E template * add docker testing back in * Auto-update of E2E template * temporarily trigger slow CI * revert to comment-driven CI * run full slow CI * CI as it should be * pyyaml fix * fix docker compose installation * test * test * update templates test * ubuntu-unit tests * restore unit tests back to normal * fix matrix for slow CI * uncomment the conditional checks * add input variable * remove mac and windows for testing * split out slow and fast integration testing * naming fix * confirm mac and windows ok" * improve hf and neuralprofet example * update the issue * update TOC (#2406) * Correct docstring in integration init file (#2408) * Fixed precedence * adding the new version to the migration tests (#2411) * update js code for github cache miss * update context to github * add discord webhooks * Add Discord webhook support for notifications * allow fallback of cache failure * ignore if weebhock fails to to many request * Add PYTORCH integration to DockerSettings --------- Co-authored-by: Alex Strick van Linschoten <[email protected]> Co-authored-by: Alex Strick van Linschoten <[email protected]> Co-authored-by: Andrei Vishniakov <[email protected]> Co-authored-by: GitHub Actions <[email protected]> Co-authored-by: Christian Versloot <[email protected]> Co-authored-by: Hamza Tahir <[email protected]> Co-authored-by: Barış Can Durak <[email protected]> * Adding the latest version id and name to the artifact response (#2430) * update TOC (#2406) * Correct docstring in integration init file (#2408) * Fixed precedence * adding the new version to the migration tests (#2411) * adding latest version name and id to artifact response * removed optional column from the conftest --------- Co-authored-by: Alex Strick van Linschoten <[email protected]> Co-authored-by: Christian Versloot <[email protected]> Co-authored-by: Hamza Tahir <[email protected]> * Adding the ID of the producer pipeline run to artifact versions (#2431) * adding producer pipeline run id to artifact versions * reverting one of the changes * fixing type * Add vulnerability notice to README (#2437) * Add security vulnerability notice to README * add CVE ID * Allow more recent `adlfs` and `s3fs` versions (#2402) * bump azure integration * bump s3 * Add new property for filtering service account events (#2405) * add new property for filtering service account activities * Auto-update of Starter template --------- Co-authored-by: GitHub Actions <[email protected]> * Add `download_files` method for `ArtifactVersion` (#2434) * add save_binary method * Fix file overwrite issue in save_artifact_binary_from_response() and improve error handling * refactor * tests ofc * add docs * linting * mypy fixes * ruff fix * coderabbit suggestions * missing docstring * docstring fix * Update artifact method name from save_binary to download_binary * more renaming (save -> download) * final rename (binary -> files) * update settings syntax * Fixing `update_model`s and revert #2402 (#2440) * fixing update models * reverting the update model changes * linting * linting * revert #2402 * revert adlfs changes --------- Co-authored-by: Andrei Vishniakov <[email protected]> Co-authored-by: Alex Strick van Linschoten <[email protected]> * Prepare release 0.55.3 (#2445) * alembic migration and bump version * release notes * add `save_models_to_registry` to CLI --------- Co-authored-by: Alex Strick van Linschoten <[email protected]> Co-authored-by: GitHub Actions <[email protected]> Co-authored-by: Christian Versloot <[email protected]> Co-authored-by: François SERRA <[email protected]> Co-authored-by: jlopezpena <[email protected]> Co-authored-by: Safoine El Khabich <[email protected]> Co-authored-by: Alex Strick van Linschoten <[email protected]> Co-authored-by: Hamza Tahir <[email protected]> Co-authored-by: Barış Can Durak <[email protected]> Co-authored-by: Jayesh Sharma <[email protected]>
adtygan
pushed a commit
to adtygan/zenml
that referenced
this pull request
Mar 21, 2024
* bump azure integration * bump s3
adtygan
pushed a commit
to adtygan/zenml
that referenced
this pull request
Mar 21, 2024
* fixing update models * reverting the update model changes * linting * linting * revert zenml-io#2402 * revert adlfs changes --------- Co-authored-by: Andrei Vishniakov <[email protected]> Co-authored-by: Alex Strick van Linschoten <[email protected]>
adtygan
pushed a commit
to adtygan/zenml
that referenced
this pull request
Mar 21, 2024
…l-io#2447) * Fix conditional statements in GitHub workflows (zenml-io#2404) * Fix conditional statements in GitHub workflows * rename core CI flows * slow CI check doesn't happen when draft * Auto-update of Starter template * fix double conditional --------- Co-authored-by: GitHub Actions <[email protected]> * Ensure proper spacing in error messages (zenml-io#2399) * Ensure proper spacing in error messages * update TOC (zenml-io#2406) --------- Co-authored-by: Alex Strick van Linschoten <[email protected]> * Fix hyperai markdown table (zenml-io#2426) * build: ⬆️ Upgrade min required google-cloud-aiplatform to 1.34.0 (zenml-io#2428) * Close code block left open in the docs (zenml-io#2432) * Fix docs * wrong ticks! * Simplify HF example and notify when cache is down (zenml-io#2300) * starter files for the new CI paradigm * disable fast/slow ci on base branch * disable core workflow * Fast/slow CI core scaffold (zenml-io#2274) * give darglint check its own job * fastCI * add slowCI * reenable fast CI * remove comment * add integration tests * fix spellcheck context * enable slow CI for testing * remove unit test dependency * fix dependency installations * yamlfixed * Comment-driven CI (zenml-io#2275) * test comment-driven approach * delete unused test file * slow CI is comment-driven * restore CI * conditionally respond to comments depending on team status * add the whole team * Update .github/workflows/ci-slow.yml Co-authored-by: Andrei Vishniakov <[email protected]> --------- Co-authored-by: Andrei Vishniakov <[email protected]> * delete old CI --------- Co-authored-by: Andrei Vishniakov <[email protected]> * remove spellcheck from slow CI * update spellcheck run conditions * Add GitHub issue creation on cache miss * test failing cache * Update Minio endpoint in setup_environment action.yml * Update minio-service endpoint in setup_environment action.yml * Sharded integration tests for Ubuntu (zenml-io#2286) * add pytest-shard dev dependency * update script for sharded testing * add ubuntu sharding * fix naming * Use `pytest-split` to shard CI (zenml-io#2296) * add split test to action * Update user authentication logic * Fix bug in login functionality * Refactor test coverage script * Update excluded directories in pyproject.toml * Update integration test script to include shard number * Update integration test script to use matrix.shard * Update caching key in setup_environment action.yml * Update durations path in test-coverage-xml.sh * Update cache key in setup_environment action.yml * Auto-update of Starter template * Fix formatting issue in setup_environment action.yml * Refactor code to improve performance and readability --------- Co-authored-by: GitHub Actions <[email protected]> * Update pyproject.toml Co-authored-by: Alex Strick van Linschoten <[email protected]> * add extra final line * make workflows use normal ubuntu) * fix durations path and update docstring --------- Co-authored-by: Safoine El Khabich <[email protected]> Co-authored-by: GitHub Actions <[email protected]> * Auto-update of Starter template * Auto-update of NLP template * Auto-update of E2E template * add docker testing back in * Auto-update of E2E template * temporarily trigger slow CI * revert to comment-driven CI * run full slow CI * CI as it should be * pyyaml fix * fix docker compose installation * test * test * update templates test * ubuntu-unit tests * restore unit tests back to normal * fix matrix for slow CI * uncomment the conditional checks * add input variable * remove mac and windows for testing * split out slow and fast integration testing * naming fix * confirm mac and windows ok" * improve hf and neuralprofet example * update the issue * update TOC (zenml-io#2406) * Correct docstring in integration init file (zenml-io#2408) * Fixed precedence * adding the new version to the migration tests (zenml-io#2411) * update js code for github cache miss * update context to github * add discord webhooks * Add Discord webhook support for notifications * allow fallback of cache failure * ignore if weebhock fails to to many request * Add PYTORCH integration to DockerSettings --------- Co-authored-by: Alex Strick van Linschoten <[email protected]> Co-authored-by: Alex Strick van Linschoten <[email protected]> Co-authored-by: Andrei Vishniakov <[email protected]> Co-authored-by: GitHub Actions <[email protected]> Co-authored-by: Christian Versloot <[email protected]> Co-authored-by: Hamza Tahir <[email protected]> Co-authored-by: Barış Can Durak <[email protected]> * Adding the latest version id and name to the artifact response (zenml-io#2430) * update TOC (zenml-io#2406) * Correct docstring in integration init file (zenml-io#2408) * Fixed precedence * adding the new version to the migration tests (zenml-io#2411) * adding latest version name and id to artifact response * removed optional column from the conftest --------- Co-authored-by: Alex Strick van Linschoten <[email protected]> Co-authored-by: Christian Versloot <[email protected]> Co-authored-by: Hamza Tahir <[email protected]> * Adding the ID of the producer pipeline run to artifact versions (zenml-io#2431) * adding producer pipeline run id to artifact versions * reverting one of the changes * fixing type * Add vulnerability notice to README (zenml-io#2437) * Add security vulnerability notice to README * add CVE ID * Allow more recent `adlfs` and `s3fs` versions (zenml-io#2402) * bump azure integration * bump s3 * Add new property for filtering service account events (zenml-io#2405) * add new property for filtering service account activities * Auto-update of Starter template --------- Co-authored-by: GitHub Actions <[email protected]> * Add `download_files` method for `ArtifactVersion` (zenml-io#2434) * add save_binary method * Fix file overwrite issue in save_artifact_binary_from_response() and improve error handling * refactor * tests ofc * add docs * linting * mypy fixes * ruff fix * coderabbit suggestions * missing docstring * docstring fix * Update artifact method name from save_binary to download_binary * more renaming (save -> download) * final rename (binary -> files) * update settings syntax * Fixing `update_model`s and revert zenml-io#2402 (zenml-io#2440) * fixing update models * reverting the update model changes * linting * linting * revert zenml-io#2402 * revert adlfs changes --------- Co-authored-by: Andrei Vishniakov <[email protected]> Co-authored-by: Alex Strick van Linschoten <[email protected]> * Prepare release 0.55.3 (zenml-io#2445) * alembic migration and bump version * release notes * add `save_models_to_registry` to CLI --------- Co-authored-by: Alex Strick van Linschoten <[email protected]> Co-authored-by: GitHub Actions <[email protected]> Co-authored-by: Christian Versloot <[email protected]> Co-authored-by: François SERRA <[email protected]> Co-authored-by: jlopezpena <[email protected]> Co-authored-by: Safoine El Khabich <[email protected]> Co-authored-by: Alex Strick van Linschoten <[email protected]> Co-authored-by: Hamza Tahir <[email protected]> Co-authored-by: Barış Can Durak <[email protected]> Co-authored-by: Jayesh Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for more recent versions of
adlfsands3fsin our azure and s3 integrations. This is to support PRs like #2376 which requires a more recent version of a dependency of the two dependencies in this PR.Summary by CodeRabbit
adlfsands3fsdependencies, enhancing compatibility.