Remove unused is-slow-ci input from fast and slow integration testing

[strickvl]

This pull request updates the conditional checks in the code to include the 'ubuntu-dind-runners' operating system as well. This ensures that the code works correctly on both 'ubuntu-latest' and 'ubuntu-dind-runners' environments.

Summary by CodeRabbit

• Chores
  • Enhanced CI workflow by adding support for an additional OS option, ubuntu-dind-runners, in both fast and slow integration tests.
  • Updated conditional logic in CI workflows to accommodate new OS option, ensuring broader compatibility and reliability in testing environments.

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Walkthrough

The updates involve refining the conditional logic in GitHub Actions workflows, specifically for integration tests. These modifications introduce a new operating system option, ubuntu-dind-runners, alongside the existing ubuntu-latest. The changes ensure that certain workflow steps, including restarting Docker, are correctly executed based on the OS and test environment selected. This adjustment enhances the flexibility and applicability of the integration testing process across different environments.

Changes

File Path	Change Summary
.github/workflows/integration-test-fast.yml .github/workflows/integration-test-slow.yml	Updated conditional statements to include ubuntu-dind-runners OS option. Adjusted logic for executing steps based on OS and test environment. Added and modified sudo systemctl restart docker step to align with new OS conditions.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[strickvl]

@coderabbitai review

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between a6a39f8 and 4876434.

Files selected for processing (2)

• .github/workflows/integration-test-fast.yml (3 hunks)
• .github/workflows/integration-test-slow.yml (3 hunks)

Additional comments: 7

.github/workflows/integration-test-fast.yml (3)

• 132-135: The conditional check for OS options and test environments is correctly updated to include ubuntu-dind-runners. This change aligns with the PR objectives to enhance compatibility with additional operating system environments.
• 167-167: The conditional check for installing Linux system dependencies has been correctly updated to include ubuntu-dind-runners. This ensures that necessary dependencies are installed for the new environment.
• 194-194: The conditional check for installing kubectl on Linux has been correctly updated to include ubuntu-dind-runners. This is crucial for ensuring Kubernetes command-line tool compatibility across different CI environments.

.github/workflows/integration-test-slow.yml (4)

• 124-127: The conditional check for maximizing space for Docker has been correctly updated to include ubuntu-dind-runners. This modification is essential for ensuring that Docker has sufficient space to operate in the new environment.
• 130-133: The conditional check for reloading Docker has been correctly updated to include ubuntu-dind-runners. This step is crucial for ensuring Docker's proper functioning in the new CI environment.
• 165-165: The conditional check for installing Linux system dependencies has been correctly updated to include ubuntu-dind-runners. This ensures that necessary dependencies are installed for the new environment, aligning with the PR's objectives.
• 192-192: The conditional check for installing kubectl on Linux has been correctly updated to include ubuntu-dind-runners. This is crucial for ensuring Kubernetes command-line tool compatibility across different CI environments.

[avishniakov]

🦭