-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry pipeline run ends #2377
Merged
Merged
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
367a7ff
Addd another event
htahir1 c588ab9
Added more context
htahir1 65b999a
Docstring
htahir1 6d5c890
Auto-update of E2E template
actions-user c96b84c
Docs
htahir1 f844ae7
python things
htahir1 b07ea2e
python things
htahir1 cec009c
python things
htahir1 a0dccef
Auto-update of Starter template
actions-user 6e33534
Merge branch 'develop' into feature/add-telemetry-pipeline-run-ends
htahir1 2d8ade3
Docstrings
htahir1 c40991b
Linting
htahir1 a080c70
Format
htahir1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,7 +61,11 @@ | |
from sqlmodel.sql.expression import Select, SelectOfScalar | ||
|
||
from zenml.analytics.enums import AnalyticsEvent | ||
from zenml.analytics.utils import analytics_disabler, track_decorator | ||
from zenml.analytics.utils import ( | ||
analytics_disabler, | ||
track_decorator, | ||
track_handler, | ||
) | ||
from zenml.config.global_config import GlobalConfiguration | ||
from zenml.config.secrets_store_config import SecretsStoreConfiguration | ||
from zenml.config.server_config import ServerConfiguration | ||
|
@@ -6688,7 +6692,20 @@ def _update_pipeline_run_status( | |
ExecutionStatus.FAILED, | ||
}: | ||
run_update.end_time = datetime.utcnow() | ||
|
||
with track_handler( | ||
AnalyticsEvent.RUN_PIPELINE_ENDED | ||
) as analytics_handler: | ||
analytics_handler.metadata = { | ||
"pipeline_run_id": pipeline_run_id, | ||
"status": new_status, | ||
"num_steps": num_steps, | ||
"start_time": pipeline_run.start_time.strftime( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. just FYI, we don't send the |
||
"%Y-%m-%dT%H:%M:%S.%fZ" | ||
), | ||
"end_time": run_update.end_time.strftime( | ||
"%Y-%m-%dT%H:%M:%S.%fZ" | ||
), | ||
} | ||
pipeline_run.update(run_update) | ||
session.add(pipeline_run) | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should also not call it
last_run
. This isn't actually the last run as someone might have created another one in the meantime, but this is exactly the run that was created by callingtraining_pipeline()
in the script above.