RBAC resource sharing #2320

schustmi · 2024-01-18T15:53:23Z

Describe changes

This PR adds a new endpoint to enable sharing single resources using RBAC.

Pre-requisites

Please ensure you have done the following:

I have read the CONTRIBUTING.md document.
If my change requires a change to docs, I have updated the documentation accordingly.
I have added tests to cover my changes.
I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Other (add details above)

coderabbitai · 2024-01-18T15:53:37Z

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

github-actions · 2024-01-18T16:05:58Z

E2E template updates in examples/e2e have been pushed.

github-actions · 2024-01-19T09:28:12Z

Quickstart template updates in examples/quickstart have been pushed.

github-actions · 2024-01-19T09:36:19Z

E2E template updates in examples/e2e have been pushed.

github-actions · 2024-01-19T09:37:33Z

NLP template updates in examples/e2e_nlp have been pushed.

AlexejPenner

Got two larger questions. Besides those you got my 🦭 of approval.

src/zenml/zen_server/rbac/zenml_cloud_rbac.py

AlexejPenner · 2024-01-19T13:00:09Z

src/zenml/zen_server/routers/users_endpoints.py

+        },
+    )
+    @handle_exceptions
+    def update_user_resource_membership(


Correct me if I'm wrong. This handles adding a Permission to a User for a Resource. How would I remove a permission?

You would remove a permission by sending an empty list of actions. I think I might have to document that in the docstring though, or do you think having two separate endpoints makes more sense. It's definitely a little confusing with the RBACInterface.share_resource(...) method name though, maybe that should have two separate methods or it should also be called RBACInterface.update_resource_membership(...)?

+1 for the renaming

…enml into feature/rbac-resource-sharing

github-actions · 2024-01-19T14:39:16Z

E2E template updates in examples/e2e have been pushed.

…enml into feature/rbac-resource-sharing

AlexejPenner

🦭

* Add endpoint for resource sharing * Auto-update of E2E template * Auto-update of Starter template * Auto-update of E2E template * Auto-update of NLP template * Rename sharing methods * Auto-update of E2E template * Fix docstrings --------- Co-authored-by: GitHub Actions <[email protected]>

Add endpoint for resource sharing

211e23f

github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Jan 18, 2024

Auto-update of E2E template

82e955c

schustmi marked this pull request as ready for review January 19, 2024 08:52

schustmi requested a review from AlexejPenner January 19, 2024 08:53

schustmi and others added 2 commits January 19, 2024 10:20

Merge branch 'develop' into feature/rbac-resource-sharing

5260ff2

Auto-update of Starter template

6f4bf86

Auto-update of E2E template

bc84ca0

Auto-update of NLP template

cc62a8f

AlexejPenner reviewed Jan 19, 2024

View reviewed changes

schustmi and others added 3 commits January 19, 2024 15:25

Rename sharing methods

1d279e6

Merge branch 'feature/rbac-resource-sharing' of github.com:zenml-io/z…

081e48a

…enml into feature/rbac-resource-sharing

Auto-update of E2E template

c04564a

schustmi requested a review from AlexejPenner January 19, 2024 14:41

schustmi added 2 commits January 22, 2024 09:14

Fix docstrings

1944ebb

Merge branch 'feature/rbac-resource-sharing' of github.com:zenml-io/z…

e4eee04

…enml into feature/rbac-resource-sharing

AlexejPenner approved these changes Jan 22, 2024

View reviewed changes

schustmi merged commit 8d18dec into develop Jan 22, 2024
31 of 32 checks passed

schustmi deleted the feature/rbac-resource-sharing branch January 22, 2024 10:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RBAC resource sharing #2320

RBAC resource sharing #2320

schustmi commented Jan 18, 2024 •

edited

Loading

coderabbitai bot commented Jan 18, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

github-actions bot commented Jan 18, 2024

github-actions bot commented Jan 19, 2024

github-actions bot commented Jan 19, 2024

github-actions bot commented Jan 19, 2024

AlexejPenner left a comment

AlexejPenner Jan 19, 2024 •

edited

Loading

schustmi Jan 19, 2024

AlexejPenner Jan 19, 2024

github-actions bot commented Jan 19, 2024

AlexejPenner left a comment

RBAC resource sharing #2320

RBAC resource sharing #2320

Conversation

schustmi commented Jan 18, 2024 • edited Loading

Describe changes

Pre-requisites

Types of changes

coderabbitai bot commented Jan 18, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

github-actions bot commented Jan 18, 2024

github-actions bot commented Jan 19, 2024

github-actions bot commented Jan 19, 2024

github-actions bot commented Jan 19, 2024

AlexejPenner left a comment

Choose a reason for hiding this comment

AlexejPenner Jan 19, 2024 • edited Loading

Choose a reason for hiding this comment

schustmi Jan 19, 2024

Choose a reason for hiding this comment

AlexejPenner Jan 19, 2024

Choose a reason for hiding this comment

github-actions bot commented Jan 19, 2024

AlexejPenner left a comment

Choose a reason for hiding this comment

schustmi commented Jan 18, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

AlexejPenner Jan 19, 2024 •

edited

Loading