Add conditional checks to prevent scheduled actions running inside forked repositories #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strickvl
added
bug
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the WalkthroughThe recent updates to the GitHub workflows introduce conditional execution based on repository checks. Jobs within various workflows now include a prerequisite that they will only run if the repository matches 'zenml-io/zenml'. This ensures that workflow actions such as analyzing code, posting data, nightly builds, labeling pull requests, publishing packages, and updating documents are specifically tailored for the ZenML repository, avoiding unintended executions in forks or other repositories. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
@coderabbitai review |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (11)
- .github/workflows/codeql.yml (1 hunks)
- .github/workflows/mixpanel-test-data.yml (1 hunks)
- .github/workflows/nightly_build.yml (1 hunks)
- .github/workflows/pr_labeler.yml (1 hunks)
- .github/workflows/publish_api_docs.yml (1 hunks)
- .github/workflows/release.yml (2 hunks)
- .github/workflows/replace_api_docs_version (1 hunks)
- .github/workflows/spellcheck.yml (1 hunks)
- .github/workflows/templates-test.yml (1 hunks)
- .github/workflows/trivy-zenml-core.yml (1 hunks)
- .github/workflows/trivy-zenserver.yml (1 hunks)
Additional comments: 16
.github/workflows/pr_labeler.yml (1)
- 10-10: The addition of the conditional check
if: github.repository == 'zenml-io/zenml'is correct and aligns with the PR's objective to restrict actions to the main repository..github/workflows/trivy-zenml-core.yml (1)
- 11-11: The addition of the conditional check
if: github.repository == 'zenml-io/zenml'is correct and aligns with the PR's objective to restrict actions to the main repository..github/workflows/trivy-zenserver.yml (1)
- 11-11: The addition of the conditional check
if: github.repository == 'zenml-io/zenml'is correct and aligns with the PR's objective to restrict actions to the main repository..github/workflows/spellcheck.yml (1)
- 18-18: The addition of the conditional check
if: github.event.pull_request.draft == false && github.repository == 'zenml-io/zenml'is correct and aligns with the PR's objective to restrict actions to the main repository..github/workflows/mixpanel-test-data.yml (1)
- 10-10: The addition of the conditional check
if: github.repository == 'zenml-io/zenml'is correct and aligns with the PR's objective to restrict actions to the main repository..github/workflows/nightly_build.yml (4)
- 16-16: The addition of the conditional check
if: github.repository == 'zenml-io/zenml'for thesetup-and-testjob is correct and aligns with the PR's objective.- 21-21: The addition of the conditional check
if: github.repository == 'zenml-io/zenml'for thepublish-python-packagejob is correct and aligns with the PR's objective.- 23-23: The addition of the conditional check
if: github.repository == 'zenml-io/zenml'for thewait-for-package-releasejob is correct and aligns with the PR's objective.- 31-31: The addition of the conditional check
if: github.repository == 'zenml-io/zenml'for thepublish-docker-imagejob is correct and aligns with the PR's objective..github/workflows/publish_api_docs.yml (1)
- 9-9: The addition of the conditional check
if: github.repository == 'zenml-io/zenml'for thepublishjob is correct and aligns with the PR's objective to restrict actions to the main repository..github/workflows/codeql.yml (1)
- 12-12: The addition of the conditional check
if: github.event.pull_request.draft == false && github.repository == 'zenml-io/zenml'for theanalyzejob is correct and aligns with the PR's objective to restrict actions to the main repository..github/workflows/replace_api_docs_version (1)
- 11-11: The addition of the conditional check
if: github.repository == 'zenml-io/zenml'for theupdate_docsjob is correct and aligns with the PR's objective to restrict actions to the main repository..github/workflows/templates-test.yml (1)
- 45-46: The addition of the conditional check
if: ${{ ! startsWith(github.event.head_commit.message, 'GitBook:') }} && github.repository == 'zenml-io/zenml'for theall-template-testsjob is correct and aligns with the PR's objective to restrict actions to the main repository..github/workflows/release.yml (3)
- 65-65: The addition of the conditional check
if: github.repository == 'zenml-io/zenml'for thepublish-python-packagejob is correct and aligns with the PR's objective.- 82-82: The addition of the conditional check
if: github.repository == 'zenml-io/zenml'for thepublish-docker-imagejob is correct and aligns with the PR's objective.- 87-87: The addition of the conditional check
if: github.repository == 'zenml-io/zenml'for thepublish-helm-chartjob is correct and aligns with the PR's objective.
|
Quickstart template updates in |
avishniakov
approved these changes
Jan 19, 2024
|
E2E template updates in |
|
NLP template updates in |
kabinja
pushed a commit
to kabinja/zenml
that referenced
this pull request
Jan 29, 2024
…rked repositories (zenml-io#2317) * add conditioal check for forks * Auto-update of Starter template * Auto-update of E2E template * Auto-update of NLP template --------- Co-authored-by: GitHub Actions <[email protected]>
adtygan
pushed a commit
to adtygan/zenml
that referenced
this pull request
Mar 21, 2024
…rked repositories (zenml-io#2317) * add conditioal check for forks * Auto-update of Starter template * Auto-update of E2E template * Auto-update of NLP template --------- Co-authored-by: GitHub Actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our scheduled actions are currently running on forked repositories. They are failing (mainly due to missing passwords etc) but still we should confine these to just running from within ZenML. Added some other conditionals in places where it seemed to make sense that we'd want to prevent these from running outside as well.
Summary by CodeRabbit
zenml-io/zenml).