Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper message for zenml up --blocking login #2290

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented Jan 15, 2024

Over on #2213 at #2213 (comment) it was raised that there's no message about what username and password to use when running zenml up --blocking. This would apply to Windows users mainly, so this PR outputs such a message.

Summary by CodeRabbit

  • New Features
    • Enhanced the server launch process with user guidance for deploying the local ZenML dashboard in a blocking mode, including connection instructions.

@strickvl strickvl added enhancement New feature or request internal To filter out internal PRs and issues labels Jan 15, 2024
Copy link
Contributor

coderabbitai bot commented Jan 15, 2024

Walkthrough

Walkthrough

The recent update to the ZenML tool includes a modification to the server management functionality. Specifically, the up function has been enhanced with a new conditional behavior. When the function is invoked with the blocking parameter set to True, it now provides a user prompt. This prompt informs users that the local ZenML dashboard is being deployed in a blocking mode and gives them the necessary details to connect to it, including a default username and instructions to use an empty password.

Changes

File Path Change Summary
src/zenml/cli/server.py Added conditional message in up function for blocking dashboard deployment with default login credentials.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@strickvl
Copy link
Contributor Author

@coderabbitai review

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 21543ef and 45a0e96.
Files selected for processing (1)
  • src/zenml/cli/server.py (1 hunks)
Additional comments: 1
src/zenml/cli/server.py (1)
  • 188-197: The addition of the message informing users about the default credentials when deploying the local ZenML dashboard in a blocking process is a good user experience enhancement. The message is clear and provides the necessary information for users to log in to the dashboard.

@strickvl strickvl merged commit 516155e into develop Jan 18, 2024
20 of 34 checks passed
@strickvl strickvl deleted the misc/improve-zenml-up-message branch January 18, 2024 08:10
kabinja pushed a commit to kabinja/zenml that referenced this pull request Jan 29, 2024
adtygan pushed a commit to adtygan/zenml that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants