-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sagemaker orchestrator and step operator env vars and other minor bugs #1993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this environment variable change also be necessary for the Sagemaker Step Operator?
I imagine it does. Step Operator use |
This logic looks good, though would love to have some test(s) added since this added functionality is fairly fiddly. |
Describe changes
This PR fixes the following issues:
zenml orchestrator flavor describe sagemaker
andzenml step-operator flavor describe sagemaker
fail because the configuration includes attributes that have aUnion
type and that is not currently supported by the CLIPre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes