-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server-Side Component Config Validation #1988
Server-Side Component Config Validation #1988
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test(s) for the updated client functionality? Otherwise looks good to me.
@strickvl I didn't add any Client functionality. Did you mean the util functions? |
You added the validation |
That was already part of the client before, all I did is refactor it out into a util function that is now called by the endpoints as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG from my side, pending a green test suite.
Describe changes
When creating or updating stack components through the dashboard, we now also validate that the component config matches the corresponding configuration class and that the component is configured correctly.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes