Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-Side Component Config Validation #1988

Merged

Conversation

fa9r
Copy link
Contributor

@fa9r fa9r commented Oct 25, 2023

Describe changes

When creating or updating stack components through the dashboard, we now also validate that the component config matches the corresponding configuration class and that the component is configured correctly.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Oct 25, 2023
Copy link
Contributor

@strickvl strickvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test(s) for the updated client functionality? Otherwise looks good to me.

@fa9r
Copy link
Contributor Author

fa9r commented Oct 26, 2023

@strickvl I didn't add any Client functionality. Did you mean the util functions?

@fa9r fa9r requested a review from strickvl October 26, 2023 12:34
@strickvl
Copy link
Contributor

You added the validation

@fa9r
Copy link
Contributor Author

fa9r commented Oct 26, 2023

You added the validation

That was already part of the client before, all I did is refactor it out into a util function that is now called by the endpoints as well

Copy link
Contributor

@strickvl strickvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG from my side, pending a green test suite.

src/zenml/stack/utils.py Outdated Show resolved Hide resolved
@fa9r fa9r requested a review from schustmi October 27, 2023 14:03
@safoinme safoinme merged commit 1ac0e53 into develop Oct 30, 2023
30 checks passed
@safoinme safoinme deleted the bugfix/OSS-2554-server-side-component-config-validation branch October 30, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants