Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLModel docs backport fixes #1975

Merged
merged 1 commit into from
Oct 24, 2023
Merged

SQLModel docs backport fixes #1975

merged 1 commit into from
Oct 24, 2023

Conversation

strickvl
Copy link
Contributor

Describe changes

I implemented/fixed _ to achieve _.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@strickvl strickvl added documentation Improvements or additions to documentation internal To filter out internal PRs and issues labels Oct 24, 2023
@strickvl strickvl merged commit 5b11230 into develop Oct 24, 2023
5 checks passed
@strickvl strickvl deleted the bugfix/sqlmodel-docs-quickfix branch October 24, 2023 07:54
strickvl added a commit that referenced this pull request Oct 24, 2023
@strickvl
docs backport fixes (#1975)
6d76fca 
(cherry picked from commit 5b11230)
safoinme
safoinme reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@safoinme safoinme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it's LGTM!

strickvl added a commit that referenced this pull request Oct 24, 2023
@strickvl
docs backport fixes (#1975) (#1976)
81c3cc0 
(cherry picked from commit 5b11230)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@safoinme safoinme safoinme left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strickvl @safoinme