Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BasePyTorchMaterliazer -> Materializer #1969

Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix: BasePyTorchMaterliazer -> Materializer #1969

merged 2 commits into from
Oct 30, 2023

Conversation

cameronraysmith
Copy link
Contributor

@cameronraysmith cameronraysmith commented Oct 20, 2023 •
edited
Loading

BasePyTorchMaterliazer contains a typo, for example, at

zenml/src/zenml/integrations/pytorch/materializers/base_pytorch_materializer.py

Line 28 in f333d27

class BasePyTorchMaterliazer(BaseMaterializer):

See this search for the incorrect form, which should become empty after merge

  • rename BasePyTorchMaterliazer to BasePyTorchMaterializer

@cameronraysmith cameronraysmith marked this pull request as ready for review October 20, 2023 19:51
strickvl
strickvl approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@strickvl strickvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Good catch. Looks good to me.

@strickvl strickvl added bug Something isn't working internal To filter out internal PRs and issues and removed internal To filter out internal PRs and issues labels Oct 23, 2023
fa9r
fa9r approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@fa9r fa9r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, good catch, thanks 👍

@safoinme safoinme merged commit 8cb758d into zenml-io:develop Oct 30, 2023
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fa9r fa9r fa9r approved these changes

@strickvl strickvl strickvl approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cameronraysmith @strickvl @fa9r @safoinme