Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightweight template CI #1930

Merged
merged 12 commits into from
Oct 11, 2023
Merged

Lightweight template CI #1930

merged 12 commits into from
Oct 11, 2023

Conversation

avishniakov
Copy link
Contributor

@avishniakov avishniakov commented Oct 11, 2023

Describe changes

I fixed issues with OS Space in Template CI action.

Diff is a bit messy, but the gist is:

  • Remove setup environment step, as it is already done as part of tests run
  • Clean-up leftovers from tests
  • Update template

Skipping full CI, tested action isolatedly: https://github.com/zenml-io/zenml/actions/runs/6483599288/job/17605563335?pr=1930

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@avishniakov avishniakov changed the base branch from main to develop October 11, 2023 13:00
@github-actions github-actions bot added the internal To filter out internal PRs and issues label Oct 11, 2023
@github-actions
Copy link
Contributor

E2E template updates in examples/e2e have been pushed.

@avishniakov avishniakov added the bug Something isn't working label Oct 11, 2023
@avishniakov avishniakov changed the title [WIP] Lightweight template CI Lightweight template CI Oct 11, 2023
@avishniakov avishniakov merged commit 1742eb6 into develop Oct 11, 2023
3 of 20 checks passed
@avishniakov avishniakov deleted the misc/lightweight-template-ci branch October 11, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants