Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve alembic branching issue #1879

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Solve alembic branching issue #1879

merged 2 commits into from
Oct 11, 2023

Conversation

avishniakov
Copy link
Contributor

@avishniakov avishniakov commented Oct 11, 2023 •
edited
Loading

Describe changes

Remove branching from Alembic by changing order.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@avishniakov avishniakov changed the base branch from main to develop October 11, 2023 07:05
@github-actions github-actions bot added the internal To filter out internal PRs and issues label Oct 11, 2023
@avishniakov avishniakov added the bug Something isn't working label Oct 11, 2023
@avishniakov avishniakov merged commit 64b60db into develop Oct 11, 2023
2 of 12 checks passed
@avishniakov avishniakov deleted the misc/alembic-branching branch October 11, 2023 07:08
@avishniakov avishniakov mentioned this pull request Oct 11, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strickvl strickvl strickvl approved these changes

@schustmi schustmi Awaiting requested review from schustmi

Assignees
No one assigned
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avishniakov @strickvl