Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slack environment variable in in generative_chat example README #1836

Conversation

bhatt-priyadutt
Copy link
Contributor

Describe changes

I implemented/fixed the Bug to where the env variable specified in the docs should be use in the code as well.

#1834

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@bhatt-priyadutt
Copy link
Contributor Author

@alex-zenml this can be merged as well

@strickvl strickvl added documentation Improvements or additions to documentation fix labels Sep 25, 2023
@strickvl
Copy link
Contributor

Thanks for this catch, @bhatt-priyadutt !

@strickvl strickvl changed the title env var renaming in gen ai example docs Fix slack environment variable in in generative_chat example README Sep 25, 2023
@strickvl strickvl merged commit 20a3dbe into zenml-io:develop Sep 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants