Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page limit adjustment #1791

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Page limit adjustment #1791

merged 2 commits into from
Sep 6, 2023

Conversation

bcdurak
Copy link
Contributor

@bcdurak bcdurak commented Sep 5, 2023

Describe changes

Minor update to the default pagination limit (from 50 -> 20)

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

AlexejPenner
AlexejPenner approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@AlexejPenner AlexejPenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@AlexejPenner
Copy link
Contributor

Although - you might need to update some docstrings that talk about the default being 50 and there is a mention of it in the docs somewhere I believe

@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Sep 5, 2023
strickvl
strickvl approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@strickvl strickvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️🛑

@bcdurak bcdurak merged commit f70aca1 into develop Sep 6, 2023
31 checks passed
@bcdurak bcdurak deleted the feature/page-limit-adjustment branch September 6, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexejPenner AlexejPenner AlexejPenner approved these changes

@strickvl strickvl strickvl approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcdurak @AlexejPenner @strickvl