Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for newer Evidently versions #1780

Merged
merged 8 commits into from
Sep 7, 2023

Conversation

fa9r
Copy link
Contributor

@fa9r fa9r commented Sep 4, 2023

Describe changes

I updated the Evidently integration to support Evidently versions >= 0.3.

The main migration was already done in #1283, I simply deleted the legacy code related to the long-removed Evidently Profile and Dashboard API which can no longer be imported in newer versions.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Sep 4, 2023
Copy link
Contributor

@strickvl strickvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll create a ticket for incorporating the new monitoring flow, since I think that'll need a bit of thought I think. Maybe something for use case #3 even? https://docs.evidentlyai.com/user-guide/monitoring/monitoring_ui

@strickvl strickvl added the dependencies Pull requests that update a dependency file label Sep 4, 2023
@fa9r fa9r removed the request for review from stefannica September 4, 2023 13:47
@fa9r fa9r requested a review from bcdurak September 4, 2023 15:31
Copy link
Contributor

@wjayesh wjayesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fa9r fa9r mentioned this pull request Sep 6, 2023
8 tasks
@fa9r fa9r merged commit d5d8d68 into develop Sep 7, 2023
31 checks passed
@fa9r fa9r deleted the feature/OSS-2375-upgrade-evidently-integration branch September 7, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants