Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the DB lock #1771

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Remove the DB lock #1771

merged 2 commits into from
Aug 31, 2023

Conversation

safoinme
Copy link
Contributor

Describe changes

We are reverting back the db lock due to the effect on alembic db migrations.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Aug 31, 2023
@safoinme safoinme requested a review from strickvl August 31, 2023 07:21
strickvl
strickvl approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@strickvl strickvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back to how it was before. Confirmed!

@safoinme safoinme merged commit ebb000a into develop Aug 31, 2023
39 of 63 checks passed
@safoinme safoinme deleted the bugfix/revert-zenml-db-lock branch August 31, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strickvl strickvl strickvl approved these changes

@AlexejPenner AlexejPenner Awaiting requested review from AlexejPenner

@stefannica stefannica Awaiting requested review from stefannica

Assignees
No one assigned
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@safoinme @strickvl