require the json content of the file instead of the path (#1874)

zenml-io · Oct 10, 2023 · bee8df7 · bee8df7
1 parent 28bbafd
commit bee8df7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/src/zenml/zen_server/deploy/helm/templates/server-secret.yaml b/src/zenml/zen_server/deploy/helm/templates/server-secret.yaml
@@ -55,7 +55,7 @@ data:
   {{- end }}
   {{- else if eq .Values.zenml.secretsStore.type "gcp" }}
   {{- if .Values.zenml.secretsStore.gcp.google_application_credentials }}
-  GOOGLE_APPLICATION_CREDENTIALS_FILE: {{ .Files.Get .Values.zenml.secretsStore.gcp.google_application_credentials | b64enc | quote }}
+  GOOGLE_APPLICATION_CREDENTIALS_FILE: {{ .Values.zenml.secretsStore.gcp.google_application_credentials | b64enc | quote }}
   {{- end }}
   {{- else if eq .Values.zenml.secretsStore.type "hashicorp" }}
   {{- if .Values.zenml.secretsStore.hashicorp.vault_token }}

diff --git a/src/zenml/zen_server/deploy/helm/values.yaml b/src/zenml/zen_server/deploy/helm/values.yaml
@@ -180,13 +180,10 @@ zenml:
       # GCP Secrets Manager service that you want to use is located.
       project_id: my-gcp-project
 
-      # Path to the GCP credentials file to use to authenticate with the GCP Secrets
-      # Manager instance. You can omit this if you are running the ZenML server
-      # in a GCP GKE cluster that uses workload identity to authenticate with
-      # GCP services without the need for credentials.
-      # NOTE: the credentials file needs to be copied in the helm chart folder
-      # and the path configured here needs to be relative to the root of the
-      # helm chart.
+      # The JSON content of the GCP credentials file to use to authenticate with 
+      # the GCP Secrets Manager instance. You can omit this if you are running 
+      # the ZenML server in a GCP GKE cluster that uses workload identity to 
+      # authenticate with GCP services without the need for credentials.
       google_application_credentials:
 
     # AWS Key Vault secrets store configuration. Only relevant if the `azure`