Skip to content

Commit

Permalink
Optimizing the CI workflows (#3145)
Browse files Browse the repository at this point in the history
* a few optimizations

* fixing the param name
  • Loading branch information
bcdurak authored and schustmi committed Oct 28, 2024
1 parent 5948af2 commit ac135cf
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 17 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/ci-fast.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ jobs:
if: github.event.pull_request.draft == false
strategy:
matrix:
# IMPORTANT: Since we are using the combination of `arc-runner-set`
# and `3.10` in our `ci-fast` workflow, this combination has been
# excluded from the `ci-slow` workflow. If you change the configuration
# here, please adjust the configuration of `ci-slow` accordingly.
os: [arc-runner-set]
python-version: ['3.10']
fail-fast: false
Expand All @@ -98,6 +102,11 @@ jobs:
if: github.event.pull_request.draft == false
strategy:
matrix:
# IMPORTANT: Since we are using the combinations of `arc-runner-set`
# `3.10` and two different test environments in our `ci-fast` workflow,
# these combination have been excluded from the `ci-slow` workflow.
# If you change the configuration here, please adjust the configuration
# of `ci-slow` accordingly.
os: [arc-runner-set]
python-version: ['3.10']
test_environment: [default, docker-server-docker-orchestrator-mysql]
Expand Down
32 changes: 15 additions & 17 deletions .github/workflows/ci-slow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,23 +39,6 @@ jobs:
run: |
echo "Please add the 'run-slow-ci' label to this PR before merging."
exit 1
docstring-check:
if: github.event.pull_request.draft == false
needs: run-slow-ci-label-is-set
runs-on: ubuntu-latest
steps:
- uses: actions/[email protected]
- name: Set up Python
uses: actions/[email protected]
with:
python-version: '3.10'
- name: Install current package as editable
run: |
curl -LsSf https://astral.sh/uv/install.sh | sh
source $HOME/.cargo/env
uv pip install --system darglint
- name: Check docstrings
run: bash scripts/docstring.sh
mysql-db-migration-testing-full:
if: github.event.pull_request.draft == false
needs: run-slow-ci-label-is-set
Expand Down Expand Up @@ -195,6 +178,12 @@ jobs:
matrix:
os: [arc-runner-set]
python-version: ['3.9', '3.10', '3.11', '3.12']
# IMPORTANT: Since we are using the following combination
# in our `ci-fast` workflow, this combination has been
# excluded from the `ci-slow` workflow.
exclude:
- os: arc-runner-set
python-version: '3.10'
fail-fast: false
uses: ./.github/workflows/unit-test.yml
with:
Expand Down Expand Up @@ -294,6 +283,15 @@ jobs:
python-version: '3.11'
- test_environment: docker-server-docker-orchestrator-mariadb
python-version: '3.12'
# IMPORTANT: Since we are using the following combinations
# in our `ci-fast` workflow, this combination has been
# excluded from the `ci-slow` workflow.
- os: arc-runner-set
test_environment: default
python-version: '3.10'
- os: arc-runner-set
test_environment: docker-server-docker-orchestrator-mysql
python-version: '3.10'
fail-fast: false
uses: ./.github/workflows/integration-test-slow.yml
with:
Expand Down

0 comments on commit ac135cf

Please sign in to comment.