-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Conversation
We had a discussion on #3731. |
IMO the module names needn't to be colorized. Besides, the color blue is not the choice I would go with since a lot of consoles come with a black background by default, if not blue ! |
Yeah, the color choice was a bit arbitrary... |
I don't think any colorization is needed here, but I'm happy with the new output. |
- made intent more clear
I've merged, because I feel the functionality makes sense, and it solves an issue I've already observed. If somebody wants to do a PR later with different colors, omission of colors, or configurable colors, that's fine. |
@Thinkscape Note that I said this:
So, submit a PR if you don't like the selected colors. |
Hi,
This is a PR that attempt to answer a problem that I outlined here: #3731
Basically, I'm using a few modules that have console commands. The problem that arised is that it quickly becomes a mess for three main reasons:
What I thought first is that getConsoleBanner was used to tell the name of the module, so that the following logic were used: banner 1, usage 1, banner 2, usage 2... However, as @Thinkscape outlined to me, banners are all appended at the beginning and should remain short (name of the module and version).
My idea is to automatically generate module name separators, with some pre-defined colors that visually separate each module. We would also need to update the doc so that people are encouraged to follow the same conventions:
For those who want to see the result, here it is (I'm open to discuss about color choices):
http://cl.ly/image/47203A0c0i1c
As you can see, the module names are all appended at the beginning in blue, while each module are separated by the module name wrapped around dashes (those take the whole console width).
What do you think ?