This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Strict mode for Date validator #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svycka
reviewed
Oct 14, 2019
src/Date.php
Outdated
| * @param bool $strict | ||
| * @return $this | ||
| */ | ||
| public function setStrict($strict) |
There was a problem hiding this comment.
maybe drop php5.6 and add boolean type-hint?
| ['6', 'd', true, false], | ||
| ['06', 'd', true, true], | ||
| [123, null, true, false], | ||
| [1340677235, null, true, false], |
There was a problem hiding this comment.
maybe also add Unix timestamp with a format here?
There was a problem hiding this comment.
The problem here is that input argument must be string even for U format. Output of DateTime::format is always a string.
svycka
approved these changes
Oct 14, 2019
froschdesign
suggested changes
Oct 15, 2019
Input must be always in the defined format and must be the same as output of format method of DateTime. Strict mode is set to `false` by default to keep BC. Resolve #33 Fix zendframework/zendframework#6407
Updates new methods of Date validator and its tests to use typehints. Updates license docblock year range.
weierophinney
approved these changes
Dec 28, 2019
There was a problem hiding this comment.
Since #264, the develop branch now targets PHP 7.1. As such, I've pushed changes to add typehints to the newly introduced methods, which will prevent BC breaks in the future, and simplifies their implementation.
I've also added documentation on the new strict mode.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input must be always in the defined format and must be the same as output
of format method of DateTime.
Strict mode is set to
falseby default to keep BC.Currently to the validator we can provide
integer,double,array,stringorDateTimeInterfacevalue. In my opinion as validator has set format we should check if the input value has exactly the same format as set.In strict mode we are comparing if:
Resolve #33
Fix zendframework/zendframework#6407
developbranch, and submit against that branch.CHANGELOG.mdentry for the new feature.I would see strict mode by default enabled in v3, or ONLY strict mode in v3.
Thoughts?
/cc @svycka @gianarb