This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
[#7504] Extract Priority in prependValidator fails on HHVM #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zendframework/zendframework#7504 Pull request for issue: Extract Priority in prependValidator fails on HHVM [#7504]
|
Hi! Thanks for this PR! Thanks |
|
Sure, I'm a little busy at the moment, but will try have them done by tomorrow. |
| } | ||
|
|
||
| $this->validators->insert( | ||
| [ | ||
| array( |
|
There is no need for tests. 3 errors has been fixed in HHVM build
|
| $queue->setExtractFlags(PriorityQueue::EXTR_PRIORITY); | ||
| $extractedNode = $queue->extract(); | ||
| $priority = $extractedNode[0] + 1; | ||
| $extractedNodes = $this->validators->toArray(\Zend\Stdlib\PriorityQueue::EXTR_PRIORITY); |
There was a problem hiding this comment.
Please replace \Zend\Stdlib\PriorityQueue with PriorityQueue
weierophinney
added a commit
that referenced
this pull request
Jun 23, 2015
[#7504] Extract Priority in prependValidator fails on HHVM
weierophinney
added a commit
that referenced
this pull request
Jun 23, 2015
weierophinney
added a commit
that referenced
this pull request
Jun 23, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zendframework/zendframework#7504
Pull request for issue: Extract Priority in prependValidator fails on HHVM [#7504]