This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61
As described in #61 in case of request uri contains "phpunit" response is always 404, because request is wrongly created from global arrays with all PHPUnit request data etc.
I think we should clear all global arrays when we run these integration tests.
I'm not sure if it has any impact on current users. All our tests pass with these changes. It would be nice to test it with some applications.
We have to set
args
(andargv
for consistency) becauseargs
is checked on constucting console request:https://github.com/zendframework/zend-console/blob/master/src/Request.php#L43-L48
and here we got before all params passed to phpunit runner.
/cc @Scyt8l3 - would you be able to test that branch with your application to check if all works correctly? Thanks!
master
branch, and submit against that branch.CHANGELOG.md
entry for the fix.