Skip to content
This repository has been archived by the owner on Feb 6, 2020. It is now read-only.

[v3] Updated migration documentation, added trait for testing migratrations #93

Closed
wants to merge 2 commits into from

Conversation

kynx
Copy link
Contributor

@kynx kynx commented Jan 28, 2016

This supersedes #87 fleshing out the migration documentation to include:

  • examples of adding normalised FQCN entries for factories
  • clear up the changes required for $shareByDefault / $sharedByDefault
  • provide example of handling plugin manager validation exceptions

It includes a trait that can be used when testing migrations to ensure aliases resolve, etc.

Note that tests will fail until #92 is merged

* @license http://framework.zend.com/license/new-bsd New BSD License
*/

namespace ZendTest\ServiceManager;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in the src/Test/ directory, and have the namespace Zend\ServiceManager\Test. Why? Because Composer typically tries to install distribution builds, and our .gitattributes file sets up distribution builds to omit the test/ directory. As such, the trait will not be present for most users unless then install with the --prefer-source flag.

Move the trait, and update the docs, and I can merge. 👍

@kynx
Copy link
Contributor Author

kynx commented Feb 2, 2016

Thanks - I've moved the test trait as requested. I'll do a separate PR against release-2.7 so any tests using it run in both.

weierophinney added a commit that referenced this pull request Feb 2, 2016
weierophinney added a commit that referenced this pull request Feb 2, 2016
@weierophinney
Copy link
Member

Cherry-picked to master for release with 3.0.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants