Skip to content
This repository has been archived by the owner on Feb 6, 2020. It is now read-only.

Use container-interop exception interfaces #46

Merged
merged 1 commit into from
Jan 11, 2016

Conversation

zerocrates
Copy link
Contributor

Fix for #45

@Maks3w
Copy link
Member

Maks3w commented Nov 4, 2015

The only thing I see ExceptionInterface is used too for LogicalException like InvalidArgumentException and these exception shouldn't be caught.

@zerocrates
Copy link
Contributor Author

Well, I was following the pattern from develop, which does the same thing (InvalidArgumentException implements ExceptionInterface which extends the interop ContainerException). I think that's the most faithful interpretation of the spec as well: it says all exceptions thrown by the container "MUST" implement ContainerException.

@weierophinney weierophinney added this to the 2.7.0 milestone Jan 11, 2016
@weierophinney weierophinney self-assigned this Jan 11, 2016
@weierophinney weierophinney merged commit 975be46 into zendframework:master Jan 11, 2016
weierophinney added a commit that referenced this pull request Jan 11, 2016
Use container-interop exception interfaces
weierophinney added a commit that referenced this pull request Jan 11, 2016
weierophinney added a commit that referenced this pull request Jan 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants