-
Notifications
You must be signed in to change notification settings - Fork 89
ASSIST - Rebase of current develop to (master with #242 applied) #251
ASSIST - Rebase of current develop to (master with #242 applied) #251
Commits on Jan 28, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 5413057 - Browse repository at this point
Copy the full SHA 5413057View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b5ddd6 - Browse repository at this point
Copy the full SHA 3b5ddd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d51cf4b - Browse repository at this point
Copy the full SHA d51cf4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 860d629 - Browse repository at this point
Copy the full SHA 860d629View commit details -
Adds class Foo test asset. To be generated by AbstractFactoryFoo on
requested name 'foo'.
Configuration menu - View commit details
-
Copy full SHA for ab26a61 - Browse repository at this point
Copy the full SHA ab26a61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c1f0d6 - Browse repository at this point
Copy the full SHA 1c1f0d6View commit details
Commits on Jan 29, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f977a4b - Browse repository at this point
Copy the full SHA f977a4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bcaf2d5 - Browse repository at this point
Copy the full SHA bcaf2d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 539cfb4 - Browse repository at this point
Copy the full SHA 539cfb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b8155e - Browse repository at this point
Copy the full SHA 3b8155eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f35a10 - Browse repository at this point
Copy the full SHA 9f35a10View commit details -
Removed tests which explicitly tested if invokables are converted to
aliases and factories. Added test to show that invokables override delegators and delegators. Added a test to show that preconfigured invokables are ignored. Fixed that problems.
Configuration menu - View commit details
-
Copy full SHA for d2650ee - Browse repository at this point
Copy the full SHA d2650eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for c94e1cf - Browse repository at this point
Copy the full SHA c94e1cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5298ab0 - Browse repository at this point
Copy the full SHA 5298ab0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5aa73cc - Browse repository at this point
Copy the full SHA 5aa73ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb3b0b1 - Browse repository at this point
Copy the full SHA cb3b0b1View commit details
Commits on Jan 31, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 8b787f2 - Browse repository at this point
Copy the full SHA 8b787f2View commit details
Commits on Feb 1, 2018
-
Deleted an assert which was assuming that invokables are handled as
combination of alias and factory, which has changed.
Configuration menu - View commit details
-
Copy full SHA for 13e0feb - Browse repository at this point
Copy the full SHA 13e0febView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0365c4b - Browse repository at this point
Copy the full SHA 0365c4bView commit details -
Split PreconfigurationGetsAppliedTest. Changed tag checking
assertObjectHasProperty/assertObjectNotHasProperty
Configuration menu - View commit details
-
Copy full SHA for 63b2302 - Browse repository at this point
Copy the full SHA 63b2302View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d36f50 - Browse repository at this point
Copy the full SHA 0d36f50View commit details -
Configuration menu - View commit details
-
Copy full SHA for e568c94 - Browse repository at this point
Copy the full SHA e568c94View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8ba1a3 - Browse repository at this point
Copy the full SHA a8ba1a3View commit details -
Had to revert access to $invokables[] to protected in order to allow
preconfiguration by child class.
Configuration menu - View commit details
-
Copy full SHA for 8e91bc6 - Browse repository at this point
Copy the full SHA 8e91bc6View commit details -
Moved object creation through factory one level down to avoid using a
reference parameter. getFactory was replaced by createObjectThroughFactory. Adjusted delegator creation accordingly.
Configuration menu - View commit details
-
Copy full SHA for de467bd - Browse repository at this point
Copy the full SHA de467bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for b27f5d0 - Browse repository at this point
Copy the full SHA b27f5d0View commit details
Commits on Feb 2, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 44a7b5b - Browse repository at this point
Copy the full SHA 44a7b5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73eadf1 - Browse repository at this point
Copy the full SHA 73eadf1View commit details
Commits on Feb 6, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 1c58b3a - Browse repository at this point
Copy the full SHA 1c58b3aView commit details
Commits on Feb 7, 2018
-
Merge pull request zendframework#6 from fhein/TEST-Prefconfiguration-…
…gets-applied Apply PR zendframework#242 to zend-master
Configuration menu - View commit details
-
Copy full SHA for 2da8ce9 - Browse repository at this point
Copy the full SHA 2da8ce9View commit details -
klemens authored and fhein committed
Feb 7, 2018 Configuration menu - View commit details
-
Copy full SHA for e6327ad - Browse repository at this point
Copy the full SHA e6327adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 146acda - Browse repository at this point
Copy the full SHA 146acdaView commit details -
updated travis build matrix lowest/locked/latest
added nightly test
Configuration menu - View commit details
-
Copy full SHA for aa73f47 - Browse repository at this point
Copy the full SHA aa73f47View commit details -
removed duplicate allow_failures
Configuration menu - View commit details
-
Copy full SHA for 7add102 - Browse repository at this point
Copy the full SHA 7add102View commit details -
Updated packages in composer to latest stable version and PHP requirements changed to PHP ^7.1 Updated suggestion in composer.
Configuration menu - View commit details
-
Copy full SHA for cc68766 - Browse repository at this point
Copy the full SHA cc68766View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4a9fb3 - Browse repository at this point
Copy the full SHA b4a9fb3View commit details -
Changed self:: to $this-> for expectException* methods
These methods are not static.
Configuration menu - View commit details
-
Copy full SHA for 751eb9b - Browse repository at this point
Copy the full SHA 751eb9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee9af6f - Browse repository at this point
Copy the full SHA ee9af6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71928a6 - Browse repository at this point
Copy the full SHA 71928a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a30310f - Browse repository at this point
Copy the full SHA a30310fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fdc16a4 - Browse repository at this point
Copy the full SHA fdc16a4View commit details -
Those optimizations target improving OPCODES.
Configuration menu - View commit details
-
Copy full SHA for 84cf057 - Browse repository at this point
Copy the full SHA 84cf057View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0df483 - Browse repository at this point
Copy the full SHA c0df483View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b2c443 - Browse repository at this point
Copy the full SHA 4b2c443View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93c6e00 - Browse repository at this point
Copy the full SHA 93c6e00View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab0179c - Browse repository at this point
Copy the full SHA ab0179cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0261db3 - Browse repository at this point
Copy the full SHA 0261db3View commit details -
Updated Travis CI configuration
- fixed env variable - CS_CHECK instead of CHECK_CS - removed --no-plugins flag as it is not needed anymore - updated actions (to conform maintainers template)
Configuration menu - View commit details
-
Copy full SHA for ec4cacb - Browse repository at this point
Copy the full SHA ec4cacbView commit details -
Removed $found variable. Reordered service resolution, so that aliases
are checked last.
Configuration menu - View commit details
-
Copy full SHA for 810005e - Browse repository at this point
Copy the full SHA 810005eView commit details -
zendframework#216 checking that the
AbstractFactory
is called with ……a resolved alias name, and not the alias itself
Configuration menu - View commit details
-
Copy full SHA for aff74e2 - Browse repository at this point
Copy the full SHA aff74e2View commit details -
Revert "Removed $found variable. Reordered service resolution, so tha…
…t aliases" This reverts commit e1ee16e.
Configuration menu - View commit details
-
Copy full SHA for 0644c1f - Browse repository at this point
Copy the full SHA 0644c1fView commit details -
Updated to php-coveralls/php-coveralls
With version 2 package has been renamed from "satooshi/php-coveralls" to "php-coveralls/php-coveralls", and the script has been renamed from "coveralls" to "php-coveralls"
Configuration menu - View commit details
-
Copy full SHA for f08b8b5 - Browse repository at this point
Copy the full SHA f08b8b5View commit details -
Added a benchmark for setService.
Optimized setService, setFactory and setShared for speed. Introduced AbstractPluginManager::setService in order to short-circuit the addition of a single service (performance, again). Streamlined naming ('validate'). A service name is valid, if there is no instance for it or override is allowed.
Configuration menu - View commit details
-
Copy full SHA for e518a32 - Browse repository at this point
Copy the full SHA e518a32View commit details -
Configuration menu - View commit details
-
Copy full SHA for a66cc49 - Browse repository at this point
Copy the full SHA a66cc49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6948d5b - Browse repository at this point
Copy the full SHA 6948d5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f956edc - Browse repository at this point
Copy the full SHA f956edcView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc6bac1 - Browse repository at this point
Copy the full SHA bc6bac1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d6c270 - Browse repository at this point
Copy the full SHA 4d6c270View commit details -
Configuration menu - View commit details
-
Copy full SHA for be7a73b - Browse repository at this point
Copy the full SHA be7a73bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce5f850 - Browse repository at this point
Copy the full SHA ce5f850View commit details -
Configuration menu - View commit details
-
Copy full SHA for adc93e0 - Browse repository at this point
Copy the full SHA adc93e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02f9244 - Browse repository at this point
Copy the full SHA 02f9244View commit details -
Removed redundant $resolvedAliases array. Aliases are resolved when
defined. Simplified CyclicAliasException.
Configuration menu - View commit details
-
Copy full SHA for 5609280 - Browse repository at this point
Copy the full SHA 5609280View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbaffd2 - Browse repository at this point
Copy the full SHA dbaffd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2de6da1 - Browse repository at this point
Copy the full SHA 2de6da1View commit details -
Merged the performance optimization of has (PR zendframework#220) bec…
…ause of the removed $resolvedAliases.
Configuration menu - View commit details
-
Copy full SHA for 22ab810 - Browse repository at this point
Copy the full SHA 22ab810View commit details -
Reintroduced CyclicAliasException::fromAliasMap(). Reintroduced test for fromAliasMap(). Removed $cyclic variable (which was for testing only). Removed CyclicAliasException::getCycle().
Configuration menu - View commit details
-
Copy full SHA for 18c3694 - Browse repository at this point
Copy the full SHA 18c3694View commit details -
Renamed validate members to validateServiceName.
validate -> validateServiceName validateArray -> validateServiceNameArray validateConfig -> validateServiceNameConfig
Configuration menu - View commit details
-
Copy full SHA for c94f2cc - Browse repository at this point
Copy the full SHA c94f2ccView commit details -
Corrected overall formatting of sprintfs. Reviewed an fixed all imports
of global functions. Renamed members as requested. Introduced constructor for ContainerModificationsNotAllowedException.
Configuration menu - View commit details
-
Copy full SHA for 1ec4f8f - Browse repository at this point
Copy the full SHA 1ec4f8fView commit details -
Added optimized algorithm for batch addition of new aliases via
configure(). The algorithm suitable for single alias addition showed up to be utterly slow (because of the immense cost of array_intersect). Removed double parethesis.
Configuration menu - View commit details
-
Copy full SHA for 0804b4e - Browse repository at this point
Copy the full SHA 0804b4eView commit details -
Fixed bug in abstract factory mock in
testAbstractFactoryShouldBeCheckedForResolvedAliasesInsteadOfAliasName. Added check of resolved aliases against abstract factories.
Configuration menu - View commit details
-
Copy full SHA for a7f9bd3 - Browse repository at this point
Copy the full SHA a7f9bd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1df0cc - Browse repository at this point
Copy the full SHA f1df0ccView commit details -
Optimized performance for setInvokableClass and handling of invokables
in configure. Removed obsolete $this->configured. Was set in configure() but only checked in trivial cases, where it was not meaningful.
Configuration menu - View commit details
-
Copy full SHA for a02d020 - Browse repository at this point
Copy the full SHA a02d020View commit details -
Reintroduced $this->configure. Assumed, configure may be called once
only this is important. Sorry.
Configuration menu - View commit details
-
Copy full SHA for 5acff67 - Browse repository at this point
Copy the full SHA 5acff67View commit details -
Configuration menu - View commit details
-
Copy full SHA for da3dab7 - Browse repository at this point
Copy the full SHA da3dab7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1454ba0 - Browse repository at this point
Copy the full SHA 1454ba0View commit details -
Removed reference to Tarjan. Added explanation why there are different
methods on how to resolve a single alias and how to resolve an array containing a mass of aliases.
Configuration menu - View commit details
-
Copy full SHA for d1a1b3f - Browse repository at this point
Copy the full SHA d1a1b3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb3fa2f - Browse repository at this point
Copy the full SHA cb3fa2fView commit details -
Unified redundant exception messages for invalid initializers and
invalid abstract factories. Moved them to Named Constructors of InvalidArgumentException. Adjusted test which checks the wording of the exception messages to reflect the change.
Configuration menu - View commit details
-
Copy full SHA for 3440736 - Browse repository at this point
Copy the full SHA 3440736View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2d9c16 - Browse repository at this point
Copy the full SHA f2d9c16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9df6662 - Browse repository at this point
Copy the full SHA 9df6662View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c9ced2 - Browse repository at this point
Copy the full SHA 2c9ced2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b35b66 - Browse repository at this point
Copy the full SHA 0b35b66View commit details -
Configuration menu - View commit details
-
Copy full SHA for 546ba35 - Browse repository at this point
Copy the full SHA 546ba35View commit details -
Removes extraneous whitespace and adds array typehint
Also updates test exception message expectations to match changes in class.
Configuration menu - View commit details
-
Copy full SHA for 3e61556 - Browse repository at this point
Copy the full SHA 3e61556View commit details -
CS/consistency fixes for InvalidArgumentException
- Adds parameter and return value annotations - Make line lengths similar - Use verbiage consistent with other exceptions - Fixes test exception expectation messages to match
Configuration menu - View commit details
-
Copy full SHA for 2b7f831 - Browse repository at this point
Copy the full SHA 2b7f831View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae0b573 - Browse repository at this point
Copy the full SHA ae0b573View commit details -
CS/consistency fixes for ServiceManager changes
- Edits comment strings for grammar, spelling, punctuation, formatting, and content. - Adds missing `@throws` annotations. - Reverses several conditionals to make exceptions conditional vs the hot path. - Edits exception messages.
Configuration menu - View commit details
-
Copy full SHA for 04b4340 - Browse repository at this point
Copy the full SHA 04b4340View commit details -
Configuration menu - View commit details
-
Copy full SHA for e19fcad - Browse repository at this point
Copy the full SHA e19fcadView commit details -
Configuration menu - View commit details
-
Copy full SHA for d66e1f5 - Browse repository at this point
Copy the full SHA d66e1f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca9cddc - Browse repository at this point
Copy the full SHA ca9cddcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96bb757 - Browse repository at this point
Copy the full SHA 96bb757View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24d643b - Browse repository at this point
Copy the full SHA 24d643bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4856629 - Browse repository at this point
Copy the full SHA 4856629View commit details -
Avoid usage of leading
\
on imported functionsSigned-off-by: Jefersson Nathan <[email protected]>
Jefersson Nathan authored and fhein committedFeb 7, 2018 Configuration menu - View commit details
-
Copy full SHA for be2ddd4 - Browse repository at this point
Copy the full SHA be2ddd4View commit details -
Adds a test to verify that build/get/has remain stable and correct over
internal state changes.
Configuration menu - View commit details
-
Copy full SHA for 1fb75a7 - Browse repository at this point
Copy the full SHA 1fb75a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78c0a26 - Browse repository at this point
Copy the full SHA 78c0a26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97b675e - Browse repository at this point
Copy the full SHA 97b675eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4061ecc - Browse repository at this point
Copy the full SHA 4061eccView commit details -
Added support for iteration over several sm configs. Added support for
scenarios with sharedByDefault === false. Test unreveals possible bug in delegator handling.
Configuration menu - View commit details
-
Copy full SHA for 62a0f82 - Browse repository at this point
Copy the full SHA 62a0f82View commit details -
Configuration menu - View commit details
-
Copy full SHA for c57cc9c - Browse repository at this point
Copy the full SHA c57cc9cView commit details -
Improved tests aliases with abstract factories.
There was an error in the testcase `testAbstractFactoryShouldBeCheckedForResolvedAliasesInsteadOfAliasName` where the returnValueMap of phpunit was used wrong. This caused a false positive. The test was returning an array which is interpreted as `TRUE`. I discovered this when I added the `testResolvedAliasFromAbstractFactory`, which should do the opposite form the earlier mentioned testcase. Beside that I found a way that the servicemanager was returning `null` instead of returning false when the last fallback on abstract factories failed.
Configuration menu - View commit details
-
Copy full SHA for 183ff34 - Browse repository at this point
Copy the full SHA 183ff34View commit details -
zendframework#241 corrected CS in newly introduced tests, removed `eq…
…ualsTo` for strings
Configuration menu - View commit details
-
Copy full SHA for 88644d4 - Browse repository at this point
Copy the full SHA 88644d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd8c93b - Browse repository at this point
Copy the full SHA bd8c93bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d07ac65 - Browse repository at this point
Copy the full SHA d07ac65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 791713e - Browse repository at this point
Copy the full SHA 791713eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cb0048 - Browse repository at this point
Copy the full SHA 6cb0048View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c28315 - Browse repository at this point
Copy the full SHA 0c28315View commit details