Skip to content
This repository has been archived by the owner on Feb 6, 2020. It is now read-only.

ASSIST - Rebase of current develop to (master with #242 applied) #251

Closed

Commits on Jan 28, 2018

  1. Configuration menu
    Copy the full SHA
    5413057 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3b5ddd6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d51cf4b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    860d629 View commit details
    Browse the repository at this point in the history
  5. Adds class Foo test asset. To be generated by AbstractFactoryFoo on

    requested name 'foo'.
    fhein committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    ab26a61 View commit details
    Browse the repository at this point in the history
  6. Fake.

    fhein committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    1c1f0d6 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2018

  1. Configuration menu
    Copy the full SHA
    f977a4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bcaf2d5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    539cfb4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3b8155e View commit details
    Browse the repository at this point in the history
  5. 3.3.2 readiness

    weierophinney committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    9f35a10 View commit details
    Browse the repository at this point in the history
  6. Removed tests which explicitly tested if invokables are converted to

    aliases and factories. Added test to show that invokables override
    delegators and delegators. Added a test to show that preconfigured
    invokables are ignored. Fixed that problems.
    fhein committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    d2650ee View commit details
    Browse the repository at this point in the history
  7. Parens added.

    fhein committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    c94e1cf View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5298ab0 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5aa73cc View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    cb3b0b1 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2018

  1. Configuration menu
    Copy the full SHA
    8b787f2 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2018

  1. Deleted an assert which was assuming that invokables are handled as

    combination of alias and factory, which has changed.
    fhein committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    13e0feb View commit details
    Browse the repository at this point in the history
  2. As requested.

    fhein committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    0365c4b View commit details
    Browse the repository at this point in the history
  3. Split PreconfigurationGetsAppliedTest. Changed tag checking

    assertObjectHasProperty/assertObjectNotHasProperty
    fhein committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    63b2302 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0d36f50 View commit details
    Browse the repository at this point in the history
  5. As requested.

    fhein committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    e568c94 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a8ba1a3 View commit details
    Browse the repository at this point in the history
  7. Had to revert access to $invokables[] to protected in order to allow

    preconfiguration by child class.
    fhein committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    8e91bc6 View commit details
    Browse the repository at this point in the history
  8. Moved object creation through factory one level down to avoid using a

    reference parameter. getFactory was replaced by
    createObjectThroughFactory. Adjusted delegator creation accordingly.
    fhein committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    de467bd View commit details
    Browse the repository at this point in the history
  9. Changed docblock.

    fhein committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    b27f5d0 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2018

  1. Configuration menu
    Copy the full SHA
    44a7b5b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    73eadf1 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2018

  1. Configuration menu
    Copy the full SHA
    1c58b3a View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2018

  1. Merge pull request zendframework#6 from fhein/TEST-Prefconfiguration-…

    …gets-applied
    
    Apply PR zendframework#242 to zend-master
    fhein authored Feb 7, 2018
    Configuration menu
    Copy the full SHA
    2da8ce9 View commit details
    Browse the repository at this point in the history
  2. spelling fixes

    klemens authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    e6327ad View commit details
    Browse the repository at this point in the history
  3. drop hhvm

    kokspflanze authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    146acda View commit details
    Browse the repository at this point in the history
  4. updated travis build matrix lowest/locked/latest

    added nightly test
    kokspflanze authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    aa73f47 View commit details
    Browse the repository at this point in the history
  5. Update .travis.yml

    removed duplicate allow_failures
    kokspflanze authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    7add102 View commit details
    Browse the repository at this point in the history
  6. Dropped PHP 5.6 and PHP 7.0

    Updated packages in composer to latest stable version and PHP requirements
    changed to PHP ^7.1
    Updated suggestion in composer.
    michalbundyra authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    cc68766 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b4a9fb3 View commit details
    Browse the repository at this point in the history
  8. Changed self:: to $this-> for expectException* methods

    These methods are not static.
    michalbundyra authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    751eb9b View commit details
    Browse the repository at this point in the history
  9. Use self:: instead of $this-> for assert* methods

    michalbundyra authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    ee9af6f View commit details
    Browse the repository at this point in the history
  10. Removed unused variables

    michalbundyra authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    71928a6 View commit details
    Browse the repository at this point in the history
  11. Removed redundant parentheses

    michalbundyra authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    a30310f View commit details
    Browse the repository at this point in the history
  12. Removed unused import

    michalbundyra authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    fdc16a4 View commit details
    Browse the repository at this point in the history
  13. Optimize PHP function calls

    Those optimizations target improving OPCODES.
    smuggli authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    84cf057 View commit details
    Browse the repository at this point in the history
  14. Optimize more PHP function calls and issets

    smuggli authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    c0df483 View commit details
    Browse the repository at this point in the history
  15. Import PHP internal functions

    michalbundyra authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    4b2c443 View commit details
    Browse the repository at this point in the history
  16. Alphabetical order of use statements

    michalbundyra authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    93c6e00 View commit details
    Browse the repository at this point in the history
  17. replace count() usage to empty when possible

    samsonasik authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    ab0179c View commit details
    Browse the repository at this point in the history
  18. replace empty() with !

    samsonasik authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    0261db3 View commit details
    Browse the repository at this point in the history
  19. Updated Travis CI configuration

    - fixed env variable - CS_CHECK instead of CHECK_CS
    - removed --no-plugins flag as it is not needed anymore
    - updated actions (to conform maintainers template)
    michalbundyra authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    ec4cacb View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    810005e View commit details
    Browse the repository at this point in the history
  21. zendframework#216 checking that the AbstractFactory is called with …

    …a resolved alias name, and not the alias itself
    Ocramius authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    aff74e2 View commit details
    Browse the repository at this point in the history
  22. Revert "Removed $found variable. Reordered service resolution, so tha…

    …t aliases"
    
    This reverts commit e1ee16e.
    Ocramius authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    0644c1f View commit details
    Browse the repository at this point in the history
  23. Updated to php-coveralls/php-coveralls

    With version 2 package has been renamed from "satooshi/php-coveralls"
    to "php-coveralls/php-coveralls", and the script has been renamed
    from "coveralls" to "php-coveralls"
    michalbundyra authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    f08b8b5 View commit details
    Browse the repository at this point in the history
  24. Added a benchmark for setService.

    Optimized setService, setFactory and setShared for speed. 
    Introduced AbstractPluginManager::setService in order to short-circuit
    the addition of a single service (performance, again).
    Streamlined naming ('validate'). A service name is valid, if there is no
    instance for it or override is allowed.
    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    e518a32 View commit details
    Browse the repository at this point in the history
  25. Speed up setAlias.

    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    a66cc49 View commit details
    Browse the repository at this point in the history
  26. Removed debug out. Puh.

    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    6948d5b View commit details
    Browse the repository at this point in the history
  27. CS tweaks.

    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    f956edc View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    bc6bac1 View commit details
    Browse the repository at this point in the history
  29. Polish.

    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    4d6c270 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    be7a73b View commit details
    Browse the repository at this point in the history
  31. Added todos.

    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    ce5f850 View commit details
    Browse the repository at this point in the history
  32. CS fixes, as usual.

    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    adc93e0 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    02f9244 View commit details
    Browse the repository at this point in the history
  34. Removed redundant $resolvedAliases array. Aliases are resolved when

    defined. Simplified CyclicAliasException.
    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    5609280 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    dbaffd2 View commit details
    Browse the repository at this point in the history
  36. Removed @todos.

    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    2de6da1 View commit details
    Browse the repository at this point in the history
  37. Merged the performance optimization of has (PR zendframework#220) bec…

    …ause of the
    
    removed $resolvedAliases.
    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    22ab810 View commit details
    Browse the repository at this point in the history
  38. Fix bc break:

    Reintroduced CyclicAliasException::fromAliasMap().
    Reintroduced test for fromAliasMap().
    Removed $cyclic variable (which was for testing only).
    Removed CyclicAliasException::getCycle().
    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    18c3694 View commit details
    Browse the repository at this point in the history
  39. Renamed validate members to validateServiceName.

    validate -> validateServiceName
    validateArray -> validateServiceNameArray
    validateConfig -> validateServiceNameConfig
    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    c94f2cc View commit details
    Browse the repository at this point in the history
  40. Corrected overall formatting of sprintfs. Reviewed an fixed all imports

    of global functions. Renamed members as requested. Introduced
    constructor for ContainerModificationsNotAllowedException.
    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    1ec4f8f View commit details
    Browse the repository at this point in the history
  41. Added optimized algorithm for batch addition of new aliases via

    configure(). The algorithm suitable for single alias addition showed up
    to be utterly slow (because of the immense cost of array_intersect).
    
    Removed double parethesis.
    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    0804b4e View commit details
    Browse the repository at this point in the history
  42. Fixed bug in abstract factory mock in

    testAbstractFactoryShouldBeCheckedForResolvedAliasesInsteadOfAliasName.
    
    Added check of resolved aliases against abstract factories.
    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    a7f9bd3 View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    f1df0cc View commit details
    Browse the repository at this point in the history
  44. Optimized performance for setInvokableClass and handling of invokables

    in configure.
    
    Removed obsolete $this->configured. Was set in configure() but only
    checked in trivial cases, where it was not meaningful.
    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    a02d020 View commit details
    Browse the repository at this point in the history
  45. Reintroduced $this->configure. Assumed, configure may be called once

    only this is important. Sorry.
    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    5acff67 View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    da3dab7 View commit details
    Browse the repository at this point in the history
  47. Fixed my fix.

    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    1454ba0 View commit details
    Browse the repository at this point in the history
  48. Removed reference to Tarjan. Added explanation why there are different

    methods on how to resolve a single alias and how to resolve an array
    containing a mass of aliases.
    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    d1a1b3f View commit details
    Browse the repository at this point in the history
  49. CS tweaks.

    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    cb3fa2f View commit details
    Browse the repository at this point in the history
  50. Unified redundant exception messages for invalid initializers and

    invalid abstract factories. Moved them to Named Constructors of
    InvalidArgumentException. Adjusted test which checks the wording of the
    exception messages to reflect the change.
    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    3440736 View commit details
    Browse the repository at this point in the history
  51. Removed obsolete emulateHas.

    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    f2d9c16 View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    9df6662 View commit details
    Browse the repository at this point in the history
  53. As requested by @webimpress

    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    2c9ced2 View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    0b35b66 View commit details
    Browse the repository at this point in the history
  55. Adds missing annotation

    weierophinney authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    546ba35 View commit details
    Browse the repository at this point in the history
  56. Removes extraneous whitespace and adds array typehint

    Also updates test exception message expectations to match changes in
    class.
    weierophinney authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    3e61556 View commit details
    Browse the repository at this point in the history
  57. CS/consistency fixes for InvalidArgumentException

    - Adds parameter and return value annotations
    - Make line lengths similar
    - Use verbiage consistent with other exceptions
    - Fixes test exception expectation messages to match
    weierophinney authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    2b7f831 View commit details
    Browse the repository at this point in the history
  58. Alphabetizes all imports in ServiceManager

    weierophinney authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    ae0b573 View commit details
    Browse the repository at this point in the history
  59. CS/consistency fixes for ServiceManager changes

    - Edits comment strings for grammar, spelling, punctuation, formatting, and content.
    - Adds missing `@throws` annotations.
    - Reverses several conditionals to make exceptions conditional vs the hot path.
    - Edits exception messages.
    weierophinney authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    04b4340 View commit details
    Browse the repository at this point in the history
  60. Adds CHANGELOG entry for zendframework#221

    weierophinney authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    e19fcad View commit details
    Browse the repository at this point in the history
  61. Configuration menu
    Copy the full SHA
    d66e1f5 View commit details
    Browse the repository at this point in the history
  62. Missing word in source doc.

    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    ca9cddc View commit details
    Browse the repository at this point in the history
  63. Removed $_.

    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    96bb757 View commit details
    Browse the repository at this point in the history
  64. Configuration menu
    Copy the full SHA
    24d643b View commit details
    Browse the repository at this point in the history
  65. Adds CHANGELOG entry for zendframework#230

    weierophinney authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    4856629 View commit details
    Browse the repository at this point in the history
  66. Avoid usage of leading \ on imported functions

    Signed-off-by: Jefersson Nathan <[email protected]>
    Jefersson Nathan authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    be2ddd4 View commit details
    Browse the repository at this point in the history
  67. Adds a test to verify that build/get/has remain stable and correct over

    internal state changes.
    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    1fb75a7 View commit details
    Browse the repository at this point in the history
  68. Changes as requested.

    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    78c0a26 View commit details
    Browse the repository at this point in the history
  69. Configuration menu
    Copy the full SHA
    97b675e View commit details
    Browse the repository at this point in the history
  70. Adds delegator scenario.

    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    4061ecc View commit details
    Browse the repository at this point in the history
  71. Added support for iteration over several sm configs. Added support for

    scenarios with sharedByDefault === false. Test unreveals possible bug in
    delegator handling.
    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    62a0f82 View commit details
    Browse the repository at this point in the history
  72. Ready for review.

    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    c57cc9c View commit details
    Browse the repository at this point in the history
  73. Improved tests aliases with abstract factories.

    There was an error in the testcase `testAbstractFactoryShouldBeCheckedForResolvedAliasesInsteadOfAliasName`
    where the returnValueMap of phpunit was used wrong. This caused a false positive. The test was returning an
    array which is interpreted as `TRUE`.
    
    I discovered this when I added the `testResolvedAliasFromAbstractFactory`, which should do the opposite form the
    earlier mentioned testcase.
    
    Beside that I found a way that the servicemanager was returning `null` instead of returning false when the last fallback
    on abstract factories failed.
    jaapio authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    183ff34 View commit details
    Browse the repository at this point in the history
  74. zendframework#241 corrected CS in newly introduced tests, removed `eq…

    …ualsTo` for strings
    Ocramius authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    88644d4 View commit details
    Browse the repository at this point in the history
  75. zendframework#241 CS (spacing)

    Ocramius authored and fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    bd8c93b View commit details
    Browse the repository at this point in the history
  76. Configuration menu
    Copy the full SHA
    d07ac65 View commit details
    Browse the repository at this point in the history
  77. Configuration menu
    Copy the full SHA
    791713e View commit details
    Browse the repository at this point in the history
  78. Configuration menu
    Copy the full SHA
    6cb0048 View commit details
    Browse the repository at this point in the history
  79. Remove differences to develop.

    fhein committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    0c28315 View commit details
    Browse the repository at this point in the history