This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 89
use default console exception template instead of empty string #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@weierophinney I think this was introduced after your SM v3 refactor and merged into 2.7 is this desired behavior or bug? If not a bug then why we have default template and overriding anyway. |
@svycka can you add unit test to cover this bug? |
in case this will not merged soon as a workaround I added default template from here https://github.com/zendframework/zend-mvc/blob/master/src/View/Console/ExceptionStrategy.php#L31-L44 to my local config like this:
@snapshotpl not sure but maybe if really needed |
@snapshotpl is it ok? |
@weierophinney this bug also is a BC break and maybe can be fixed faster? |
weierophinney
added a commit
that referenced
this pull request
Apr 6, 2016
use default console exception template instead of empty string
weierophinney
added a commit
that referenced
this pull request
Apr 6, 2016
weierophinney
added a commit
that referenced
this pull request
Apr 6, 2016
@svycka Merged, and tagged 2.7.5. Can you do a similar PR against zend-mvc-console, please? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was overriding default template if no template is set.
also the method name and config option name 'exception_message' is not very clear what it is :D