Fix invalid abstract service factory configuration

[codeaid]

This fixes #129.

Registration of InputFilterAbstractServiceFactory is currently invalid in ConfigProvider. Instead of the abstract_factories key being nested under dependencies it should be nested under input_filters.

This pull request corrects the behaviour and allows using the service with no manual changes required when using the library in a Zend Expressive project.

• Are you fixing a bug?
  • Detail how the bug is invoked currently.
  • Detail the original, incorrect behavior.
  • Detail the new, expected behavior.
  • Base your feature on the master branch, and submit against that branch.
  • Add a regression test that demonstrates the bug, and proves the fix.
    Is this really needed? I've included tests that validate the current (correct) behaviour.
  • Add a CHANGELOG.md entry for the fix.

[michalbundyra]

@codeaid It looks like desired behaviour, please see:
https://docs.zendframework.com/zend-inputfilter/specs/#setup

[codeaid]

@webimpress Sorry, not sure what you meant. Is something wrong with the config?

[michalbundyra]

@codeaid Documentation says that you have to add it manually in your configuration when you using zend-mvc v2. With v3 or expressive the configuration is slightly different and your change is not needed, imho.

[codeaid]

Documenation says "when using the configuration manager [..] the functionality is enabled by default" - I registered ConfigProvider in my Expressive application (installed using the instructions on the project homepage) and I wasn't able to use the abstract factory. How does it get enabled by default then?

Edit:
Also, what's the purpose of having this section added to dependencies if it's not even invoked?

[froschdesign]

Please add the correct link for documentation: https://docs.zendframework.com/zend-inputfilter/specs/#setup

[froschdesign]

Fix is okay! 👍

(Btw. the same problem in zend-form.)

[michalbundyra]

@codeaid @froschdesign Oh, yeah... sorry you have right. The fix is right 👍 We creates another 'service manager' for input filters, and the abstract factory should be registered there.

[codeaid]

Ah, I thought I was going crazy for a moment! Glad I can be of help after all.

I force-pushed the updated link in the changelog to avoid duplicate commits. Everything should be alright now.
On a side note - would you want me to fix this issue in zend-form too while I'm at it, @froschdesign?

[froschdesign]

@codeaid

would you want me to fix this issue in zend-form too while I'm at it

That would be awesome! 👍

[weierophinney]

Thanks, @codeaid!

[codeaid]

Thanks, @weierophinney! Sorry, I haven't had time to fix this issue in zend-form. Been busy with things other than PHP.