Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Enable online tests and Proxy adapter tests + various fixes covered by these tests #198

Merged
merged 10 commits into from
Nov 29, 2019
Merged

Enable online tests and Proxy adapter tests + various fixes covered by these tests #198

merged 10 commits into from
Nov 29, 2019

Conversation

michalbundyra
Copy link
Member

  • Are you fixing a bug?
    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.

This PR enables online tests and tests for adapters which were before skipped.
Enabling tests shows multiple various errors in different part of the library:

  • wrong merging options in Curl adapter - constants has int values, so it was not possible to override the same option
  • type of parameter is not checked in Proxy::setOptions
  • exception was thrown when empty content has been written through Proxy adapter

Travis CI is using apache with configured forward proxy so all tests can now run.

@michalbundyra michalbundyra added this to the 2.10.1 milestone Nov 29, 2019
michalbundyra added a commit that referenced this pull request Nov 29, 2019
Enable online tests and Proxy adapter tests + various fixes covered by these tests
michalbundyra added a commit that referenced this pull request Nov 29, 2019
michalbundyra added a commit that referenced this pull request Nov 29, 2019
@michalbundyra michalbundyra merged commit cacf22e into zendframework:master Nov 29, 2019
@michalbundyra michalbundyra deleted the hotfix/travis-tests branch November 29, 2019 20:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant