remove upper casing first character on headers in socker class

zendframework · Nov 13, 2018 · e0620b1 · e0620b1
1 parent bdfe6ca
commit e0620b1
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/src/Client/Adapter/Socket.php b/src/Client/Adapter/Socket.php
@@ -381,7 +381,7 @@ public function write($method, $uri, $httpVer = '1.1', $headers = [], $body = ''
         $request = $method . ' ' . $path . ' HTTP/' . $httpVer . "\r\n";
         foreach ($headers as $k => $v) {
             if (is_string($k)) {
-                $v = ucfirst($k) . ': ' . $v;
+                $v = $k . ': ' . $v;
             }
             $request .= $v . "\r\n";
         }

diff --git a/src/Client/Adapter/Test.php b/src/Client/Adapter/Test.php
@@ -132,7 +132,7 @@ public function write($method, $uri, $httpVer = '1.1', $headers = [], $body = ''
         $request = $method . ' ' . $path . ' HTTP/' . $httpVer . "\r\n";
         foreach ($headers as $k => $v) {
             if (is_string($k)) {
-                $v = ucfirst($k) . ': ' . $v;
+                $v = $k . ': ' . $v;
             }
             $request .= $v . "\r\n";
         }

diff --git a/test/Client/SocketTest.php b/test/Client/SocketTest.php
@@ -309,6 +309,24 @@ public function testAllowsZeroWrittenBytes()
         $this->_adapter->write('GET', new Uri('tcp://localhost:80/'), '1.1', [], 'test body');
     }
 
+    /**
+     * Verifies that the headers are being set as given without changing any
+     * character case.
+     */
+    public function testCaseInsensitiveHeaders()
+    {
+        $this->_adapter->connect('localhost');
+        $requestString = $this->_adapter->write(
+            'GET',
+            new Uri('tcp://localhost:80/'),
+            '1.1',
+            ['x-test-header' => 'someTestHeader'],
+            'someTestBody'
+        );
+
+        $this->assertContains('x-test-header', $requestString);
+    }
+
     /**
      * Data Providers
      */